Enable RVO (return value optimization).

camilasan · camilasan · commit 0b873443a5fe · 2024-07-03T16:23:33.000+02:00
Signed-off-by: Camila Ayres &lt;hello@camilasan.com&gt;
diff --git a/src/libsync/configfile.cpp b/src/libsync/configfile.cpp
@@ -705,14 +705,15 @@ QString ConfigFile::defaultUpdateChannel() const
 
 QString ConfigFile::currentUpdateChannel() const
 {
+    auto updateChannel = defaultUpdateChannel();
     QSettings settings(configFile(), QSettings::IniFormat);
-    if (const auto configUpdateChannel = settings.value(QLatin1String(updateChannelC), defaultUpdateChannel()).toString();
+    if (const auto configUpdateChannel = settings.value(QLatin1String(updateChannelC), updateChannel).toString();
         validUpdateChannels().contains(configUpdateChannel)) {
         qCWarning(lcConfigFile()) << "Config file has a valid update channel:" << configUpdateChannel;
-        return configUpdateChannel;
+        updateChannel = configUpdateChannel;
     }
 
-    return defaultUpdateChannel();
+    return updateChannel;
 }
 
 void ConfigFile::setUpdateChannel(const QString &channel)

Original file line number	Diff line number	Diff line change
`@@ -705,14 +705,15 @@ QString ConfigFile::defaultUpdateChannel() const`
`705`	`705`
`706`	`706`	`QString ConfigFile::currentUpdateChannel() const`
`707`	`707`	`{`
	`708`	`+ auto updateChannel = defaultUpdateChannel();`
`708`	`709`	`QSettings settings(configFile(), QSettings::IniFormat);`
`709`		`- if (const auto configUpdateChannel = settings.value(QLatin1String(updateChannelC), defaultUpdateChannel()).toString();`
	`710`	`+ if (const auto configUpdateChannel = settings.value(QLatin1String(updateChannelC), updateChannel).toString();`
`710`	`711`	`validUpdateChannels().contains(configUpdateChannel)) {`
`711`	`712`	`qCWarning(lcConfigFile()) << "Config file has a valid update channel:" << configUpdateChannel;`
`712`		`- return configUpdateChannel;`
	`713`	`+ updateChannel = configUpdateChannel;`
`713`	`714`	`}`
`714`	`715`
`715`		`- return defaultUpdateChannel();`
	`716`	`+ return updateChannel;`
`716`	`717`	`}`
`717`	`718`
`718`	`719`	`void ConfigFile::setUpdateChannel(const QString &channel)`