Skip to content

Commit 38055c2

Browse files
committed
fix: Writable check on debug archive destination directory.
Signed-off-by: Iva Horn <[email protected]>
1 parent 42749bc commit 38055c2

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/gui/generalsettings.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,10 @@ QVector<ZipEntry> createDebugArchiveFileList()
119119

120120
bool createDebugArchive(const QString &filename)
121121
{
122-
const auto fileInfo = QFileInfo(filename);
123-
const auto dirInfo = QFileInfo(fileInfo.dir().absolutePath());
124-
if (!dirInfo.isWritable()) {
122+
const auto entries = createDebugArchiveFileList();
123+
124+
KZip zip(filename);
125+
if (!zip.open(QIODevice::WriteOnly)) {
125126
QMessageBox::critical(
126127
nullptr,
127128
QObject::tr("Failed to create debug archive"),
@@ -131,11 +132,6 @@ bool createDebugArchive(const QString &filename)
131132
return false;
132133
}
133134

134-
const auto entries = createDebugArchiveFileList();
135-
136-
KZip zip(filename);
137-
zip.open(QIODevice::WriteOnly);
138-
139135
for (const auto &entry : entries) {
140136
zip.addLocalFile(entry.localFilename, entry.zipFilename);
141137
}

0 commit comments

Comments
 (0)