Skip to content

Commit 38d0c1a

Browse files
committed
fix(gui): prevent nullptr dereference when VFS mode is unavailable
Prevent reaching a code path in Utility::askExperimentalVirtualFilesFeature that would cause a null pointer dereference. Assisted-by: Qwen:qwen-3.6-35b-a3b Signed-off-by: Troed Sångberg <github@troed.se>
1 parent 4c3e369 commit 38d0c1a

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

src/gui/accountsettings.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,10 @@ void AccountSettings::slotCustomContextMenuRequested(const QPoint &pos)
769769

770770
if (const auto mode = bestAvailableVfsMode();
771771
!Theme::instance()->disableVirtualFilesSyncFolder() &&
772-
Theme::instance()->showVirtualFilesOption() && !folder->virtualFilesEnabled() && Vfs::checkAvailability(folder->path(), mode)) {
772+
Theme::instance()->showVirtualFilesOption() &&
773+
!folder->virtualFilesEnabled() &&
774+
mode != Vfs::Off &&
775+
Vfs::checkAvailability(folder->path(), mode)) {
773776
if (mode == Vfs::WindowsCfApi || ConfigFile().showExperimentalOptions()) {
774777
ac = menu->addAction(tr("Enable virtual file support %1 …").arg(mode == Vfs::WindowsCfApi ? QString() : tr("(experimental)")));
775778
// TODO: remove when UX decision is made

0 commit comments

Comments
 (0)