Const and autofy ignorelisttablewidget

Signed-off-by: Claudio Cambra <[email protected]>

Author: claucambra

src/gui/ignorelisttablewidget.cpp

@@ -27,11 +27,11 @@ IgnoreListTableWidget::IgnoreListTableWidget(QWidget *parent)
                                      "This is useful for meta data."));
 
     ui->removePushButton->setEnabled(false);
-    connect(ui->tableWidget,         &QTableWidget::itemSelectionChanged,
+    connect(ui->tableWidget, &QTableWidget::itemSelectionChanged,
             this, &IgnoreListTableWidget::slotItemSelectionChanged);
-    connect(ui->removePushButton,    &QAbstractButton::clicked,
+    connect(ui->removePushButton, &QAbstractButton::clicked,
             this, &IgnoreListTableWidget::slotRemoveCurrentItem);
-    connect(ui->addPushButton,       &QAbstractButton::clicked,
+    connect(ui->addPushButton, &QAbstractButton::clicked,
             this, &IgnoreListTableWidget::slotAddPattern);
     connect(ui->removeAllPushButton, &QAbstractButton::clicked,
             this, &IgnoreListTableWidget::slotRemoveAllItems);
@@ -48,13 +48,13 @@ IgnoreListTableWidget::~IgnoreListTableWidget()
 
 void IgnoreListTableWidget::slotItemSelectionChanged()
 {
-    QTableWidgetItem *item = ui->tableWidget->currentItem();
+    const auto item = ui->tableWidget->currentItem();
     if (!item) {
         ui->removePushButton->setEnabled(false);
         return;
     }
 
-    bool enable = item->flags() & Qt::ItemIsEnabled;
+    const auto enable = item->flags() & Qt::ItemIsEnabled;
     ui->removePushButton->setEnabled(enable);
 }
 
@@ -70,15 +70,18 @@ void IgnoreListTableWidget::slotRemoveAllItems()
     ui->tableWidget->setRowCount(0);
 }
 
-void IgnoreListTableWidget::slotWriteIgnoreFile(const QString & file)
+void IgnoreListTableWidget::slotWriteIgnoreFile(const QString &file)
 {
     QFile ignores(file);
+
     if (ignores.open(QIODevice::WriteOnly)) {
         // rewrites the whole file since now the user can also remove system patterns
         QFile::resize(file, 0);
-        for (int row = 0; row < ui->tableWidget->rowCount(); ++row) {
-            QTableWidgetItem *patternItem = ui->tableWidget->item(row, patternCol);
-            QTableWidgetItem *deletableItem = ui->tableWidget->item(row, deletableCol);
+
+        for (auto row = 0; row < ui->tableWidget->rowCount(); ++row) {
+            const auto patternItem = ui->tableWidget->item(row, patternCol);
+            const auto deletableItem = ui->tableWidget->item(row, deletableCol);
+
             if (patternItem->flags() & Qt::ItemIsEnabled) {
                 QByteArray prepend;
                 if (deletableItem->checkState() == Qt::Checked) {
@@ -90,12 +93,13 @@ void IgnoreListTableWidget::slotWriteIgnoreFile(const QString & file)
             }
         }
     } else {
-        QMessageBox::warning(this, tr("Could not open file"),
-            tr("Cannot write changes to \"%1\".").arg(file));
+        QMessageBox::warning(this,
+                             tr("Could not open file"),
+                             tr("Cannot write changes to \"%1\".").arg(file));
     }
     ignores.close(); //close the file before reloading stuff.
 
-    FolderMan *folderMan = FolderMan::instance();
+    const auto folderMan = FolderMan::instance();
 
     // We need to force a remote discovery after a change of the ignore list.
     // Otherwise we would not download the files/directories that are no longer
@@ -108,10 +112,13 @@ void IgnoreListTableWidget::slotWriteIgnoreFile(const QString & file)
 
 void IgnoreListTableWidget::slotAddPattern()
 {
-    bool okClicked = false;
-    QString pattern = QInputDialog::getText(this, tr("Add Ignore Pattern"),
-        tr("Add a new ignore pattern:"),
-        QLineEdit::Normal, QString(), &okClicked);
+    auto okClicked = false;
+    const auto pattern = QInputDialog::getText(this,
+                                               tr("Add Ignore Pattern"),
+                                               tr("Add a new ignore pattern:"),
+                                               QLineEdit::Normal,
+                                               {},
+                                               &okClicked);
 
     if (!okClicked || pattern.isEmpty())
         return;
@@ -120,18 +127,20 @@ void IgnoreListTableWidget::slotAddPattern()
     ui->tableWidget->scrollToBottom();
 }
 
-void IgnoreListTableWidget::readIgnoreFile(const QString &file, bool readOnly)
+void IgnoreListTableWidget::readIgnoreFile(const QString &file, const bool readOnly)
 {
     QFile ignores(file);
+
     if (ignores.open(QIODevice::ReadOnly)) {
         while (!ignores.atEnd()) {
-            QString line = QString::fromUtf8(ignores.readLine());
+            auto line = QString::fromUtf8(ignores.readLine());
             line.chop(1);
             if (line == QStringLiteral("\\#*#")) {
                 continue;
             }
+
             if (!line.isEmpty() && !line.startsWith("#")) {
-                bool deletable = false;
+                auto deletable = false;
                 if (line.startsWith(']')) {
                     deletable = true;
                     line = line.mid(1);
@@ -142,16 +151,16 @@ void IgnoreListTableWidget::readIgnoreFile(const QString &file, bool readOnly)
     }
 }
 
-int IgnoreListTableWidget::addPattern(const QString &pattern, bool deletable, bool readOnly)
+int IgnoreListTableWidget::addPattern(const QString &pattern, const bool deletable, const bool readOnly)
 {
-    int newRow = ui->tableWidget->rowCount();
+    const auto newRow = ui->tableWidget->rowCount();
     ui->tableWidget->setRowCount(newRow + 1);
 
-    auto *patternItem = new QTableWidgetItem;
+    const auto patternItem = new QTableWidgetItem;
     patternItem->setText(pattern);
     ui->tableWidget->setItem(newRow, patternCol, patternItem);
 
-    auto *deletableItem = new QTableWidgetItem;
+    const auto deletableItem = new QTableWidgetItem;
     deletableItem->setFlags(Qt::ItemIsUserCheckable | Qt::ItemIsEnabled);
     deletableItem->setCheckState(deletable ? Qt::Checked : Qt::Unchecked);
     ui->tableWidget->setItem(newRow, deletableCol, deletableItem);

src/gui/ignorelisttablewidget.h

@@ -23,7 +23,7 @@ class IgnoreListTableWidget : public QWidget
 
 public slots:
     void slotRemoveAllItems();
-    void slotWriteIgnoreFile(const QString & file);
+    void slotWriteIgnoreFile(const QString &file);
 
 private slots:
     void slotItemSelectionChanged();