Skip to content

Commit a78b990

Browse files
committed
fix(macOS): Writable check on debug archive destination directory.
Signed-off-by: Iva Horn <[email protected]>
1 parent 2969975 commit a78b990

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/gui/generalsettings.cpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,23 +119,21 @@ QVector<ZipEntry> createDebugArchiveFileList()
119119

120120
bool createDebugArchive(const QString &filename)
121121
{
122-
const auto fileInfo = QFileInfo(filename);
123-
const auto dirInfo = QFileInfo(fileInfo.dir().absolutePath());
124-
if (!dirInfo.isWritable()) {
122+
const auto entries = createDebugArchiveFileList();
123+
124+
KZip zip(filename);
125+
126+
if (!zip.open(QIODevice::WriteOnly)) {
125127
QMessageBox::critical(
126128
nullptr,
127129
QObject::tr("Failed to create debug archive"),
128130
QObject::tr("Could not create debug archive in selected location!"),
129131
QMessageBox::Ok
130132
);
133+
131134
return false;
132135
}
133136

134-
const auto entries = createDebugArchiveFileList();
135-
136-
KZip zip(filename);
137-
zip.open(QIODevice::WriteOnly);
138-
139137
for (const auto &entry : entries) {
140138
zip.addLocalFile(entry.localFilename, entry.zipFilename);
141139
}

0 commit comments

Comments
 (0)