Merge pull request #7781 from nextcloud/bugfix/readOnlyClassicalSyncLnkShortcutsWindows

mgallien · web-flow · commit c6b1a0d6d0c0 · 2025-01-22T14:02:16.000+01:00
fix the if check for invalid virtual LNK files
diff --git a/src/libsync/discovery.cpp b/src/libsync/discovery.cpp
@@ -1679,7 +1679,7 @@ void ProcessDirectoryJob::processFileFinalize(
         item->_type = CSyncEnums::ItemTypeVirtualFileDehydration;
     }
 
-    if (item->_instruction != CSyncEnums::CSYNC_INSTRUCTION_NONE &&
+    if (item->_instruction == CSyncEnums::CSYNC_INSTRUCTION_NONE &&
         !item->isDirectory() &&
         _discoveryData->_syncOptions._vfs &&
         _discoveryData->_syncOptions._vfs->mode() == OCC::Vfs::Off &&

Original file line number	Diff line number	Diff line change
`@@ -1679,7 +1679,7 @@ void ProcessDirectoryJob::processFileFinalize(`
`1679`	`1679`	`item->_type = CSyncEnums::ItemTypeVirtualFileDehydration;`
`1680`	`1680`	`}`
`1681`	`1681`
`1682`		`- if (item->_instruction != CSyncEnums::CSYNC_INSTRUCTION_NONE &&`
	`1682`	`+ if (item->_instruction == CSyncEnums::CSYNC_INSTRUCTION_NONE &&`
`1683`	`1683`	`!item->isDirectory() &&`
`1684`	`1684`	`_discoveryData->_syncOptions._vfs &&`
`1685`	`1685`	`_discoveryData->_syncOptions._vfs->mode() == OCC::Vfs::Off &&`