Skip to content

Commit d485acc

Browse files
Integral-TechIntegral-Tech
committed
refactor: replace QString() with QStringLiteral() for better performance
Signed-off-by: Integral <[email protected]>
1 parent 0a52cc2 commit d485acc

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+144
-144
lines changed

‎src/cmd/cmd.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ int main(int argc, char **argv)
315315

316316
#ifdef Q_OS_WIN
317317
// Ensure OpenSSL config file is only loaded from app directory
318-
QString opensslConf = QCoreApplication::applicationDirPath() + QString("/openssl.cnf");
318+
QString opensslConf = QCoreApplication::applicationDirPath() + QStringLiteral("/openssl.cnf");
319319
qputenv("OPENSSL_CONF", opensslConf.toLocal8Bit());
320320
#endif
321321

‎src/gui/application.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ Application::Application(int &argc, char **argv)
222222

223223
#ifdef Q_OS_WIN
224224
// Ensure OpenSSL config file is only loaded from app directory
225-
QString opensslConf = QCoreApplication::applicationDirPath() + QString("/openssl.cnf");
225+
QString opensslConf = QCoreApplication::applicationDirPath() + QStringLiteral("/openssl.cnf");
226226
qputenv("OPENSSL_CONF", opensslConf.toLocal8Bit());
227227
#endif
228228

‎src/gui/cloudproviders/cloudproviderwrapper.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ CloudProviderWrapper::CloudProviderWrapper(QObject *parent, Folder *folder, int
3636
{
3737
GMenuModel *model = nullptr;
3838
GActionGroup *action_group = nullptr;
39-
QString accountName = QString("Folder/%1").arg(folderId);
39+
QString accountName = QStringLiteral("Folder/%1").arg(folderId);
4040

4141
_cloudProvider = CLOUD_PROVIDERS_PROVIDER_EXPORTER(cloudprovider);
4242
_cloudProviderAccount = cloud_providers_account_exporter_new(_cloudProvider, accountName.toUtf8().data());
@@ -170,7 +170,7 @@ void CloudProviderWrapper::slotUpdateProgress(const QString &folder, const Progr
170170

171171
void CloudProviderWrapper::updateStatusText(QString statusText)
172172
{
173-
QString status = QString("%1 - %2").arg(_folder->accountState()->stateString(_folder->accountState()->state()), statusText);
173+
QString status = QStringLiteral("%1 - %2").arg(_folder->accountState()->stateString(_folder->accountState()->state()), statusText);
174174
cloud_providers_account_exporter_set_status_details(_cloudProviderAccount, status.toUtf8().data());
175175
}
176176

‎src/gui/creds/flow2auth.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ void Flow2Auth::slotPollTimerTimeout()
198198
req.setHeader(QNetworkRequest::ContentTypeHeader, "application/x-www-form-urlencoded");
199199

200200
auto requestBody = new QBuffer;
201-
QUrlQuery arguments(QString("token=%1").arg(_pollToken));
201+
QUrlQuery arguments(QStringLiteral("token=%1").arg(_pollToken));
202202
requestBody->setData(arguments.query(QUrl::FullyEncoded).toLatin1());
203203

204204
auto job = _account->sendRequest("POST", _pollEndpoint, req, requestBody);

‎src/gui/filedetails/sharemodel.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,7 @@ QString ShareModel::avatarUrlForShare(const SharePtr &share) const
788788
const auto provider = QStringLiteral("image://tray-image-provider/");
789789
const auto userId = share->getShareWith()->shareWith();
790790
const auto avatarUrl = Utility::concatUrlPath(_accountState->account()->url(),
791-
QString("remote.php/dav/avatars/%1/%2.png").arg(userId, QString::number(64))).toString();
791+
QStringLiteral("remote.php/dav/avatars/%1/%2.png").arg(userId, QString::number(64))).toString();
792792
return QString(provider + avatarUrl);
793793
}
794794

@@ -1464,7 +1464,7 @@ QString ShareModel::generatePassword()
14641464
static const QRegularExpression lowercaseMatch("[a-z]");
14651465
static const QRegularExpression uppercaseMatch("[A-Z]");
14661466
static const QRegularExpression numberMatch("[0-9]");
1467-
static const QRegularExpression specialCharMatch(QString("[%1]").arg(specialChars.data()));
1467+
static const QRegularExpression specialCharMatch(QStringLiteral("[%1]").arg(specialChars.data()));
14681468

14691469
static const std::map<std::string_view, QRegularExpression> matchMap{
14701470
{lowercaseAlphabet, lowercaseMatch},

‎src/gui/foldercreationdialog.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ FolderCreationDialog::FolderCreationDialog(const QString &destination, QWidget *
4545
ui->newFolderNameEdit->setText(suggestedFolderNamePrefix);
4646
} else {
4747
for (unsigned int i = 2; i < std::numeric_limits<unsigned int>::max(); ++i) {
48-
const QString suggestedPostfix = QString(" (%1)").arg(i);
48+
const QString suggestedPostfix = QStringLiteral(" (%1)").arg(i);
4949

5050
if (!QDir(newFolderFullPath + suggestedPostfix).exists()) {
5151
ui->newFolderNameEdit->setText(suggestedFolderNamePrefix + suggestedPostfix);

‎src/gui/folderstatusmodel.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ QVariant FolderStatusModel::data(const QModelIndex &index, int role) const
219219
case Qt::DisplayRole:
220220
if (folderInfo->_hasError) {
221221
return {tr("Error while loading the list of folders from the server.")
222-
+ QString("\n")
222+
+ QStringLiteral("\n")
223223
+ folderInfo->_lastErrorString};
224224
} else {
225225
return tr("Fetching folder list from server …");

‎src/gui/ocssharejob.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ void OcsShareJob::getShares(const QString &path, const QMap<QString, QString> &p
3333
setVerb("GET");
3434

3535
addParam(QString::fromLatin1("path"), path);
36-
addParam(QString::fromLatin1("reshares"), QString("true"));
37-
addParam(QString::fromLatin1("shared_with_me"), QString("true"));
36+
addParam(QString::fromLatin1("reshares"), QStringLiteral("true"));
37+
addParam(QString::fromLatin1("shared_with_me"), QStringLiteral("true"));
3838

3939
for (auto it = std::cbegin(params); it != std::cend(params); ++it) {
4040
addParam(it.key(), it.value());

‎src/gui/remotewipe.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ void RemoteWipe::startCheckJobWithAppPassword(QString pwd){
5858
request.setUrl(requestUrl);
5959
request.setSslConfiguration(_account->getOrCreateSslConfig());
6060
auto requestBody = new QBuffer;
61-
QUrlQuery arguments(QString("token=%1").arg(_appPassword));
61+
QUrlQuery arguments(QStringLiteral("token=%1").arg(_appPassword));
6262
requestBody->setData(arguments.query(QUrl::FullyEncoded).toLatin1());
6363
_networkReplyCheck = _networkManager.post(request, requestBody);
6464
QObject::connect(&_networkManager, &QNetworkAccessManager::sslErrors,
@@ -79,16 +79,16 @@ void RemoteWipe::checkJobSlot()
7979
jsonParseError.error != QJsonParseError::NoError) {
8080
QString errorFromJson = json["error"].toString();
8181
if (!errorFromJson.isEmpty()) {
82-
qCWarning(lcRemoteWipe) << QString("Error returned from the server: <em>%1<em>")
82+
qCWarning(lcRemoteWipe) << QStringLiteral("Error returned from the server: <em>%1<em>")
8383
.arg(errorFromJson.toHtmlEscaped());
8484
} else if (_networkReplyCheck->error() != QNetworkReply::NoError) {
85-
qCWarning(lcRemoteWipe) << QString("There was an error accessing the 'token' endpoint: <br><em>%1</em>")
85+
qCWarning(lcRemoteWipe) << QStringLiteral("There was an error accessing the 'token' endpoint: <br><em>%1</em>")
8686
.arg(_networkReplyCheck->errorString().toHtmlEscaped());
8787
} else if (jsonParseError.error != QJsonParseError::NoError) {
88-
qCWarning(lcRemoteWipe) << QString("Could not parse the JSON returned from the server: <br><em>%1</em>")
88+
qCWarning(lcRemoteWipe) << QStringLiteral("Could not parse the JSON returned from the server: <br><em>%1</em>")
8989
.arg(jsonParseError.errorString());
9090
} else {
91-
qCWarning(lcRemoteWipe) << QString("The reply from the server did not contain all expected fields");
91+
qCWarning(lcRemoteWipe) << QStringLiteral("The reply from the server did not contain all expected fields");
9292
}
9393

9494
// check for wipe request
@@ -136,7 +136,7 @@ void RemoteWipe::notifyServerSuccessJob(AccountState *accountState, bool dataWip
136136
request.setUrl(requestUrl);
137137
request.setSslConfiguration(_account->getOrCreateSslConfig());
138138
auto requestBody = new QBuffer;
139-
QUrlQuery arguments(QString("token=%1").arg(_appPassword));
139+
QUrlQuery arguments(QStringLiteral("token=%1").arg(_appPassword));
140140
requestBody->setData(arguments.query(QUrl::FullyEncoded).toLatin1());
141141
_networkReplySuccess = _networkManager.post(request, requestBody);
142142
QObject::connect(_networkReplySuccess, &QNetworkReply::finished, this,
@@ -153,16 +153,16 @@ void RemoteWipe::notifyServerSuccessJobSlot()
153153
jsonParseError.error != QJsonParseError::NoError) {
154154
QString errorFromJson = json["error"].toString();
155155
if (!errorFromJson.isEmpty()) {
156-
qCWarning(lcRemoteWipe) << QString("Error returned from the server: <em>%1</em>")
156+
qCWarning(lcRemoteWipe) << QStringLiteral("Error returned from the server: <em>%1</em>")
157157
.arg(errorFromJson.toHtmlEscaped());
158158
} else if (_networkReplySuccess->error() != QNetworkReply::NoError) {
159-
qCWarning(lcRemoteWipe) << QString("There was an error accessing the 'success' endpoint: <br><em>%1</em>")
159+
qCWarning(lcRemoteWipe) << QStringLiteral("There was an error accessing the 'success' endpoint: <br><em>%1</em>")
160160
.arg(_networkReplySuccess->errorString().toHtmlEscaped());
161161
} else if (jsonParseError.error != QJsonParseError::NoError) {
162-
qCWarning(lcRemoteWipe) << QString("Could not parse the JSON returned from the server: <br><em>%1</em>")
162+
qCWarning(lcRemoteWipe) << QStringLiteral("Could not parse the JSON returned from the server: <br><em>%1</em>")
163163
.arg(jsonParseError.errorString());
164164
} else {
165-
qCWarning(lcRemoteWipe) << QString("The reply from the server did not contain all expected fields.");
165+
qCWarning(lcRemoteWipe) << QStringLiteral("The reply from the server did not contain all expected fields.");
166166
}
167167
}
168168

‎src/gui/socketapi/socketapi.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,13 +1151,13 @@ void SocketApi::command_GET_STRINGS(const QString &argument, SocketListener *lis
11511151
{ "EMAIL_PRIVATE_LINK_MENU_TITLE", tr("Send private link by email …") },
11521152
{ "CONTEXT_MENU_ICON", APPLICATION_ICON_NAME },
11531153
} };
1154-
listener->sendMessage(QString("GET_STRINGS:BEGIN"));
1154+
listener->sendMessage(QStringLiteral("GET_STRINGS:BEGIN"));
11551155
for (const auto& key_value : strings) {
11561156
if (argument.isEmpty() || argument == QLatin1String(key_value.first)) {
1157-
listener->sendMessage(QString("STRING:%1:%2").arg(key_value.first, key_value.second));
1157+
listener->sendMessage(QStringLiteral("STRING:%1:%2").arg(key_value.first, key_value.second));
11581158
}
11591159
}
1160-
listener->sendMessage(QString("GET_STRINGS:END"));
1160+
listener->sendMessage(QStringLiteral("GET_STRINGS:END"));
11611161
}
11621162

11631163
void SocketApi::sendSharingContextMenuOptions(const FileData &fileData, SocketListener *listener, SharingContextItemEncryptedFlag itemEncryptionFlag, SharingContextItemRootEncryptedFolderFlag rootE2eeFolderFlag)
@@ -1325,7 +1325,7 @@ SocketApi::FileData SocketApi::FileData::parentFolder() const
13251325

13261326
void SocketApi::command_GET_MENU_ITEMS(const QString &argument, OCC::SocketListener *listener)
13271327
{
1328-
listener->sendMessage(QString("GET_MENU_ITEMS:BEGIN"), true);
1328+
listener->sendMessage(QStringLiteral("GET_MENU_ITEMS:BEGIN"), true);
13291329
const QStringList files = split(argument);
13301330

13311331
// Find the common sync folder.
@@ -1483,7 +1483,7 @@ void SocketApi::command_GET_MENU_ITEMS(const QString &argument, OCC::SocketListe
14831483
}
14841484
}
14851485

1486-
listener->sendMessage(QString("GET_MENU_ITEMS:END"));
1486+
listener->sendMessage(QStringLiteral("GET_MENU_ITEMS:END"));
14871487
}
14881488

14891489
DirectEditor* SocketApi::getDirectEditorForLocalFile(const QString &localFile)

‎src/gui/syncrunfilelog.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ void SyncRunFileLog::start(const QString &folderPath)
5252
if(QString::compare(folderPath,line,Qt::CaseSensitive)!=0) {
5353
depthIndex++;
5454
if(depthIndex <= length) {
55-
filenameSingle = folderPath.split(QLatin1String("/")).at(length - depthIndex) + QString("_") ///
55+
filenameSingle = folderPath.split(QLatin1String("/")).at(length - depthIndex) + QStringLiteral("_") ///
5656
+ filenameSingle;
5757
filename = logpath+ QLatin1String("/") + filenameSingle + QLatin1String("_sync.log");
5858
}

‎src/gui/tray/unifiedsearchresultslistmodel.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ void UnifiedSearchResultsListModel::slotSearchTermEditingFinished()
383383
&UnifiedSearchResultsListModel::slotSearchTermEditingFinished);
384384

385385
if (!_accountState || !_accountState->account()) {
386-
qCCritical(lcUnifiedSearch) << QString("Account state is invalid. Could not start search!");
386+
qCCritical(lcUnifiedSearch) << QStringLiteral("Account state is invalid. Could not start search!");
387387
return;
388388
}
389389

@@ -401,14 +401,14 @@ void UnifiedSearchResultsListModel::slotFetchProvidersFinished(const QJsonDocume
401401
const auto job = qobject_cast<JsonApiJob *>(sender());
402402

403403
if (!job) {
404-
qCCritical(lcUnifiedSearch) << QString("Failed to fetch providers.").arg(_searchTerm);
404+
qCCritical(lcUnifiedSearch) << QStringLiteral("Failed to fetch providers.").arg(_searchTerm);
405405
_errorString += tr("Failed to fetch providers.") + QLatin1Char('\n');
406406
emit errorStringChanged();
407407
return;
408408
}
409409

410410
if (statusCode != 200) {
411-
qCCritical(lcUnifiedSearch) << QString("%1: Failed to fetch search providers for '%2'. Error: %3")
411+
qCCritical(lcUnifiedSearch) << QStringLiteral("%1: Failed to fetch search providers for '%2'. Error: %3")
412412
.arg(statusCode)
413413
.arg(_searchTerm)
414414
.arg(job->errorString());
@@ -446,7 +446,7 @@ void UnifiedSearchResultsListModel::slotSearchForProviderFinished(const QJsonDoc
446446
const auto job = qobject_cast<JsonApiJob *>(sender());
447447

448448
if (!job) {
449-
qCCritical(lcUnifiedSearch) << QString("Search has failed for '%2'.").arg(_searchTerm);
449+
qCCritical(lcUnifiedSearch) << QStringLiteral("Search has failed for '%2'.").arg(_searchTerm);
450450
_errorString += tr("Search has failed for '%2'.").arg(_searchTerm) + QLatin1Char('\n');
451451
emit errorStringChanged();
452452
return;
@@ -471,7 +471,7 @@ void UnifiedSearchResultsListModel::slotSearchForProviderFinished(const QJsonDoc
471471
}
472472

473473
if (statusCode != 200) {
474-
qCCritical(lcUnifiedSearch) << QString("%1: Search has failed for '%2'. Error: %3")
474+
qCCritical(lcUnifiedSearch) << QStringLiteral("%1: Search has failed for '%2'. Error: %3")
475475
.arg(statusCode)
476476
.arg(_searchTerm)
477477
.arg(job->errorString());

‎src/gui/updater/ocupdater.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ void OCUpdater::slotStartInstaller()
221221
};
222222

223223
QString msiLogFile = cfg.configPath() + "msi.log";
224-
QString command = QString("&{msiexec /i '%1' /L*V '%2'| Out-Null ; &'%3'}")
224+
QString command = QStringLiteral("&{msiexec /i '%1' /L*V '%2'| Out-Null ; &'%3'}")
225225
.arg(preparePathForPowershell(updateFile))
226226
.arg(preparePathForPowershell(msiLogFile))
227227
.arg(preparePathForPowershell(QCoreApplication::applicationFilePath()));

‎src/gui/updater/updateinfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ UpdateInfo UpdateInfo::parseString(const QString &xml, bool *ok)
8888
if (const auto result = doc.setContent(xml); !result) {
8989
qCWarning(lcUpdater).noquote().nospace() << result.errorMessage << " at " << result.errorLine << "," << result.errorColumn
9090
<< "\n" << xml.split("\n").value(result.errorLine - 1) << "\n"
91-
<< QString(" ").repeated(result.errorColumn - 1) << "^\n"
91+
<< QStringLiteral(" ").repeated(result.errorColumn - 1) << "^\n"
9292
<< "->" << xml << "<-";
9393
if (ok)
9494
*ok = false;

‎src/gui/wizard/flow2authwidget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ void Flow2AuthWidget::slotStatusChanged(Flow2Auth::PollStatus status, int second
158158
_statusUpdateSkipCount--;
159159
break;
160160
}
161-
_ui.statusLabel->setText(tr("Waiting for authorization") + QString("… (%1)").arg(secondsLeft));
161+
_ui.statusLabel->setText(tr("Waiting for authorization") + QStringLiteral("… (%1)").arg(secondsLeft));
162162
stopSpinner(true);
163163
break;
164164
case Flow2Auth::statusPollNow:

‎src/gui/wizard/welcomepage.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ void WelcomePage::styleSlideShow()
7171
_ui->slideShow->addSlide(wizardTalkIconFileName, tr("Screensharing, online meetings & web conferences"));
7272

7373
const auto isDarkBackground = Theme::isDarkColor(backgroundColor);
74-
_ui->slideShowNextButton->setIcon(theme->uiThemeIcon(QString("control-next.svg"), isDarkBackground));
75-
_ui->slideShowPreviousButton->setIcon(theme->uiThemeIcon(QString("control-prev.svg"), isDarkBackground));
74+
_ui->slideShowNextButton->setIcon(theme->uiThemeIcon(QStringLiteral("control-next.svg"), isDarkBackground));
75+
_ui->slideShowPreviousButton->setIcon(theme->uiThemeIcon(QStringLiteral("control-prev.svg"), isDarkBackground));
7676
}
7777

7878
void WelcomePage::setupSlideShow()

‎src/libsync/abstractnetworkjob.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ void AbstractNetworkJob::start()
358358
_timer.start();
359359

360360
const QUrl url = account()->url();
361-
const QString displayUrl = QString("%1://%2%3").arg(url.scheme()).arg(url.host()).arg(url.path());
361+
const QString displayUrl = QStringLiteral("%1://%2%3").arg(url.scheme()).arg(url.host()).arg(url.path());
362362

363363
QString parentMetaObjectName = parent() ? parent()->metaObject()->className() : "";
364364
qCInfo(lcNetworkJob) << metaObject()->className() << "created for" << displayUrl << "+" << path() << parentMetaObjectName;

‎src/libsync/account.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ QString Account::displayName() const
164164
credentialsUser = _credentials->user();
165165
}
166166

167-
auto displayName = QString("%1@%2").arg(credentialsUser, _url.host());
167+
auto displayName = QStringLiteral("%1@%2").arg(credentialsUser, _url.host());
168168
const auto port = url().port();
169169
if (port > 0 && port != 80 && port != 443) {
170170
displayName.append(QLatin1Char(':'));

‎src/libsync/clientproxy.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ const char *ClientProxy::proxyTypeToCStr(QNetworkProxy::ProxyType type)
7878

7979
QString ClientProxy::printQNetworkProxy(const QNetworkProxy &proxy)
8080
{
81-
return QString("%1://%2:%3").arg(proxyTypeToCStr(proxy.type())).arg(proxy.hostName()).arg(proxy.port());
81+
return QStringLiteral("%1://%2:%3").arg(proxyTypeToCStr(proxy.type())).arg(proxy.hostName()).arg(proxy.port());
8282
}
8383

8484
void ClientProxy::setupQtProxyFromConfig()

‎src/libsync/configfile.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ QString ConfigFile::backup(const QString &fileName) const
463463
}
464464

465465
QString backupFile =
466-
QString("%1.backup_%2%3")
466+
QStringLiteral("%1.backup_%2%3")
467467
.arg(baseFilePath)
468468
.arg(QDateTime::currentDateTime().toString("yyyyMMdd_HHmmss"))
469469
.arg(versionString);

‎src/libsync/creds/keychainchunk.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ void WriteJob::slotWriteJobDone(QKeychain::Job *incomingJob)
205205
return;
206206
}
207207

208-
const QString keyWithIndex = _key + (index > 0 ? (QString(".") + QString::number(index)) : QString());
208+
const QString keyWithIndex = _key + (index > 0 ? (QStringLiteral(".") + QString::number(index)) : QString());
209209
const QString kck = _account ? AbstractCredentials::keychainKey(
210210
_account->url().toString(),
211211
keyWithIndex,
@@ -313,7 +313,7 @@ void ReadJob::slotReadJobDone(QKeychain::Job *incomingJob)
313313
#if defined(Q_OS_WIN)
314314
// try to fetch next chunk
315315
if (_chunkCount < KeychainChunk::MaxChunks) {
316-
const QString keyWithIndex = _key + QString(".") + QString::number(_chunkCount);
316+
const QString keyWithIndex = _key + QStringLiteral(".") + QString::number(_chunkCount);
317317
const QString kck = _account ? AbstractCredentials::keychainKey(
318318
_account->url().toString(),
319319
keyWithIndex,
@@ -442,7 +442,7 @@ void DeleteJob::slotDeleteJobDone(QKeychain::Job *incomingJob)
442442
#if defined(Q_OS_WIN)
443443
// try to delete next chunk
444444
if (_chunkCount < KeychainChunk::MaxChunks) {
445-
const QString keyWithIndex = _key + QString(".") + QString::number(_chunkCount);
445+
const QString keyWithIndex = _key + QStringLiteral(".") + QString::number(_chunkCount);
446446
const QString kck = _account ? AbstractCredentials::keychainKey(
447447
_account->url().toString(),
448448
keyWithIndex,

0 commit comments

Comments
 (0)