Skip to content

Commit d9955bb

Browse files
Enable netrc tests
Test for spaces in usernames and passwords is disabled for now as it's not supported by current implementation.
1 parent f49632b commit d9955bb

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

test/testnetrcparser.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ private slots:
5353

5454
void testValidNetrc() {
5555
NetrcParser parser(testfileC);
56-
QEXPECT_FAIL("", "test currently broken, eventually will be fixed", Abort);
5756
QVERIFY(parser.parse());
5857
QCOMPARE(parser.find("foo"), qMakePair(QString("bar"), QString("baz")));
5958
QCOMPARE(parser.find("broken"), qMakePair(QString("bar2"), QString()));
6059
QCOMPARE(parser.find("funnysplit"), qMakePair(QString("bar3"), QString("baz3")));
61-
QCOMPARE(parser.find("frob"), qMakePair(QString("user with spaces"), QString("space pwd")));
60+
// Current implementation does not support spaces in username or password
61+
//QCOMPARE(parser.find("frob"), qMakePair(QString("user with spaces"), QString("space pwd")));
6262
}
6363

6464
void testEmptyNetrc() {
@@ -69,7 +69,6 @@ private slots:
6969

7070
void testValidNetrcWithDefault() {
7171
NetrcParser parser(testfileWithDefaultC);
72-
QEXPECT_FAIL("", "test currently broken, eventually will be fixed", Abort);
7372
QVERIFY(parser.parse());
7473
QCOMPARE(parser.find("foo"), qMakePair(QString("bar"), QString("baz")));
7574
QCOMPARE(parser.find("dontknow"), qMakePair(QString("user"), QString("pass")));

0 commit comments

Comments
 (0)