fix(migration): remove const from legacyData().

legacyData() calls setDiscoveredLegacyConfigPath() and setLegacyData()
on this, which are non const methods. Marking the function const was
wrong since it has side effects and GCC/Clang both reject it with
-Werror. Remove the const qualifier.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Author: camilasan

src/libsync/settings/migration.cpp

@@ -141,7 +141,7 @@ void Migration::resetForTesting()
     _legacyData = {};
 }
 
-Migration::LegacyData Migration::legacyData() const
+Migration::LegacyData Migration::legacyData()
 {
     qCInfo(lcMigration) << "Migrate: restoreFromLegacySettings, checking settings group" << Theme::instance()->appName();
 

src/libsync/settings/migration.h

@@ -90,7 +90,7 @@ class OWNCLOUDSYNC_EXPORT Migration
     void setUpgradeType(const UpgradeType type);
 
     /// Returns QSettings from a legacy config file
-    [[nodiscard]] LegacyData legacyData() const;
+    [[nodiscard]] LegacyData legacyData();
     void setLegacyData(const LegacyData legacyData);
 
     /// Set during first time migration of legacy accounts in AccountManager