feat(UI): Account wizard redesign by Rello · Pull Request #10030 · nextcloud/desktop

Rello · 2026-05-14T12:10:14Z

closing #8822

Full replacement of old account wizard by QML implementation
All features need to be be available in the new version
Rework of the dependent sub-screens for proxy or advanced sync settings
removal of the old implementation
removal of the TOS related parts in the wizard, because this is handled by the "grand access" screen already
no other modals should be affected (e.g. account removal popup)

Tested:

none/enforce-multi-URL
no-proxy setting (should hide the button)
TOS active
[ ]

kra-mo · 2026-05-15T09:06:18Z

@kra-mo wdyt?

I mean, obvious points of feedback are that the input field should be as big as the "Log in" button and the side/bottom padding for buttons should be equal, plus the buttons on the first screen should all take up as much width as possible, like on the second screen. The "Authorize this device in the browser window that opened." string can also be removed and the icons made the same as on the mockup. The colors of the primary buttons also don't meet contrast requirements, I don’t know where this color is from.

Generally just getting it in-line with the mockup.

kra-mo · 2026-05-15T09:07:17Z

Plus the "Add Nextcloud account" window title can be made invisible on Mac here. Each screen should give you enough context on its own.

Rello · 2026-05-15T15:09:51Z

Rello · 2026-05-27T12:28:51Z

@kra-mo can you re-check the current screenshots? if ok we will do win/linux also

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9995d5f252

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kra-mo

Looks fine enough.

Rello · 2026-05-28T08:52:38Z

implementing missing features like TOS and shares

Rello · 2026-05-28T10:05:48Z

Multi-URL setting

Connect to Share

mgallien

the proxy popup is not being reset when closed and will open with the previous state if open again

Rello · 2026-05-28T10:59:11Z

the proxy popup is not being reset when closed and will open with the previous state if open again

but should it? if you did the effort to enter e.g. a long password, you do not want to have it reset by making a wrong click

mgallien · 2026-05-28T12:14:08Z

the proxy popup is not being reset when closed and will open with the previous state if open again

but should it? if you did the effort to enter e.g. a long password, you do not want to have it reset by making a wrong click

in classic real popup, you delete the first popup item and when opening the new one, you would only get default values (unless you explicitly save previous value and reuse them)
I would keep previous behavior to minimize the surprises (other such dialogs in desktop client do not reuse previous state)
I also forgot to mention that using a not real popup via qml may be an issue when selecting manual proxy mode because the enclosing window may be too small to display it correctly (see my snapshot)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68ff9bcfe3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jancborchardt

Looks good to me from what you showed also in person @Rello! :)

The button text looks a bit large on Windows though?

Rello · 2026-06-01T12:37:07Z

also forgot to mention that using a not real popup via qml may be an issue when selecting manual proxy mode because the enclosing window may be too small to display it correctly (see my snapshot)

do you have more details for me? I see it fits the window?

mgallien · 2026-06-01T13:49:29Z

latest Windows light mode screenshots

mgallien · 2026-06-01T13:51:41Z

@Rello just noticed a small issue when compared to the previous account wizard
it used to default to https scheme in case none are put in the server address text entry filed
the new one will default to http which we would prefer not to select by default (I guess)

mgallien · 2026-06-01T13:57:45Z

broken windows dark mode

Rello · 2026-06-01T15:45:57Z

broken windows dark mode

Hello @kra-mo
now that we heavily customised the light mode to fit what we need, we loose the dynamics of dark/light switches.
I would suggest that we keep the only-light-mode.
the impact for the user is rather limited, but implementing dual mode might be more effort.
what do you think?

kra-mo · 2026-06-02T06:50:19Z

Dark mode is also an accessibility feature and we should not compromise on that.

Rello · 2026-06-02T09:22:09Z

@kra-mo would this be sufficient?

kra-mo · 2026-06-02T09:25:32Z

Looks fine

mgallien · 2026-06-02T14:53:07Z

I missed it in previous snapshots
at least on windows
the input entry for the proxy port number looks weird

it renders 8080 in mathematics format which seems unexpected (at least for me)

mgallien · 2026-06-02T14:53:22Z

light and dark mode seemed correct
🎉

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92cbcea255

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47461e1ce2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-03T09:07:57Z

+
+            spacing: 14
+
+            EnforcedPlainTextLabel {


Import the tray label type before loading the wizard

Because AccountWizardWindow.qml is loaded directly by QQmlComponent, its imports must make every type in this file resolvable. EnforcedPlainTextLabel lives in src/gui/tray and the other wizard QML files import it with ../../tray, but this root file does not, so QML reports EnforcedPlainTextLabel is not a type and the account wizard component fails to instantiate when opening the redesigned setup wizard.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa870081b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-03T12:40:57Z

+    if (canUseVirtualFiles()) {
+        _syncMode = VirtualFiles;


Avoid defaulting to experimental virtual files

On non-macOS/non-Windows builds where bestAvailableVfsMode() is the experimental suffix backend, canUseVirtualFiles() is still true, so this preselects VirtualFiles before the user reaches the sync-options page. Pressing Done then creates a virtual-files sync without the experimental warning/opt-in the legacy advanced page required; keep the default to classic sync except for the stable CfAPI/File Provider cases, or prompt before switching.

Useful? React with 👍 / 👎.

Signed-off-by: Rello <github@scherello.de>

github-actions · 2026-06-03T19:24:08Z

Artifact containing the AppImage: nextcloud-appimage-pr-10030.zip

Digest: sha256:0e9824fb3c3b09f65f74600b0e8cb9a3ee2ae8638f51502c428acfc7347c1bbd

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarqubecloud · 2026-06-03T20:03:37Z

Quality Gate failed

Failed conditions
2 Security Hotspots
16.6% Coverage on New Code (required ≥ 80%)
180 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Rello moved this to 🏗️ In progress in 💻 Desktop Clients team May 14, 2026

Rello added this to 💻 Desktop Clients team May 14, 2026

Rello self-assigned this May 14, 2026

Rello added the design Design, UI, UX, etc. label May 14, 2026

This comment was marked as outdated.

Sign in to view

Rello requested review from jancborchardt and kra-mo May 27, 2026 19:04

Rello added this to the 34.0.0 milestone May 27, 2026

Rello marked this pull request as ready for review May 27, 2026 19:04

Rello requested review from camilasan, i2h3, mgallien and nilsding as code owners May 27, 2026 19:04

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

Comment thread src/gui/wizard/accountwizardcontroller.cpp Outdated

Comment thread src/gui/owncloudsetupwizard.cpp

kra-mo approved these changes May 28, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

mgallien requested changes May 28, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

Rello force-pushed the feature/AccountWizard branch from 7eeeb50 to 2e9222f Compare May 28, 2026 12:02

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread src/gui/wizard/qml/AccountWizardWindow.qml Outdated

jancborchardt approved these changes May 28, 2026

View reviewed changes

Rello marked this pull request as draft June 1, 2026 06:57

mgallien marked this pull request as ready for review June 2, 2026 17:34

mgallien force-pushed the feature/AccountWizard branch from 55bbcb1 to 7c172f1 Compare June 2, 2026 17:34

mgallien approved these changes Jun 2, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread src/gui/wizard/accountwizardcontroller.cpp

Comment thread src/gui/wizard/accountwizardcontroller.cpp Outdated

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Rello force-pushed the feature/AccountWizard branch from d4b3975 to a942377 Compare June 3, 2026 19:13

feat: add QML account wizard

bb0c69e

Signed-off-by: Rello <github@scherello.de>

Rello force-pushed the feature/AccountWizard branch from a942377 to bb0c69e Compare June 3, 2026 19:16

Rello enabled auto-merge June 3, 2026 19:52

Rello disabled auto-merge June 3, 2026 19:53

camilasan approved these changes Jun 3, 2026

View reviewed changes

Conversation

Rello commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

kra-mo commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kra-mo commented May 15, 2026

Uh oh!

Rello commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rello commented May 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

kra-mo left a comment

Choose a reason for hiding this comment

Uh oh!

Rello commented May 28, 2026

Uh oh!

Rello commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

mgallien left a comment

Choose a reason for hiding this comment

Uh oh!

Rello commented May 28, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

mgallien commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

Rello commented Jun 1, 2026

Uh oh!

mgallien commented Jun 1, 2026

Uh oh!

mgallien commented Jun 1, 2026

Uh oh!

mgallien commented Jun 1, 2026

Uh oh!

Rello commented Jun 1, 2026

Uh oh!

kra-mo commented Jun 2, 2026

Uh oh!

Rello commented Jun 2, 2026

Uh oh!

kra-mo commented Jun 2, 2026

Uh oh!

mgallien commented Jun 2, 2026

Uh oh!

mgallien commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Rello commented May 14, 2026 •

edited

Loading

kra-mo commented May 15, 2026 •

edited

Loading

Rello commented May 15, 2026 •

edited

Loading

Rello commented May 28, 2026 •

edited

Loading