[Bug]: Nautilus integration: Nextcloud shares shown twice

[lightonflux]

• This is a bug, not a question or a configuration issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• I agree to follow Nextcloud's Code of Conduct

Bug description

The nautilus integration shows nextcloud shares twice:

Steps to reproduce

1. Have nautilus v45.1, Nextcloud Client 3.10.0 (Fedora) and nextcloud-client-nautilus (same version, but different package on fedora).
2. Add two shares / nextcloud targets in the client. (Maybe also happens with one share too).
3. Open nautilus
4. Observe

Expected behavior

Each share should only be displayed once. Redundancy is not necessary and confusing.

Which files are affected by this bug

/usr/share/nautilus-python/extensions/syncstate-Nextcloud.py

Operating system

Linux

Which version of the operating system you are running.

Fedora 39

Package

Distro package manager

Nextcloud Server version

27.1.3

Nextcloud Desktop Client version

3.10.0

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 3.3.6 to 3.4.0)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

• Default internal user-backend

Nextcloud Server logs

No response

Additional info

I wasn't sure if this is a nautilus or nextcloud. So here is the bug report for nautilus:

https://gitlab.gnome.org/GNOME/nautilus/-/issues/3169

[mbiebl]

I can reproduce this issue:

Using version Debian sid, nextcloud-desktop is version 3.10.0-1, nautilus is version 44.2.1-2

[mbiebl]

I've downgraded https://packages.debian.org/unstable/nautilus-nextcloud to 3.7.3-1 (from Debian stable), and the duplicate icons are gone.

[lightonflux]

The sysncstate.py has not changed between these versions.

[mbiebl]

Running git bisect shows 2829710 as the first faulty commit

28297106af4b3e22e97982c6ee12abfca09ce46c is the first bad commit
commit 28297106af4b3e22e97982c6ee12abfca09ce46c
Author: Corentin Noël <corentin.noel@collabora.com>
Date:   Wed Sep 6 16:04:15 2023 +0200

    Add compatibility with the new libcloudproviders integration
    
    Since libcloudproviders 0.3.3 it is possible to specify the interface name directly
    in the .desktop file, and thus allowing it to be integrated when using a containerized
    client.
    
    Signed-off-by: Corentin Noël <corentin.noel@collabora.com>

 mirall.desktop.in      | 2 +-
 src/gui/CMakeLists.txt | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

[mbiebl]

@tintou ^

[mbiebl]

$ apt-cache policy libcloudproviders0 
libcloudproviders0:
  Installiert:           0.3.4-1
  Installationskandidat: 0.3.4-1
  Versionstabelle:
 *** 0.3.4-1 500
        500 http://ftp.debian.org/debian sid/main amd64 Packages
        100 /var/lib/dpkg/status

[mbiebl]

Removing the four lines

Implements=org.freedesktop.CloudProviders

[org.freedesktop.CloudProviders]
BusName=com.nextcloudgmbh.Nextcloud
ObjectPath=/com/nextcloudgmbh/Nextcloud

from /usr/share/applications/com.nextcloud.desktopclient.nextcloud.desktop fixes the duplicate icons in nautilus.

[tintou]

The debian package shouldn't install the .in in /usr/share/cloud-providers when there is libcloudproviders 0.3.3+ available in the system as these files are now "legacy"

[tintou]

This for instance allows the flatpak version of the desktop client to now be working out of the box.

[mbiebl]

Hm, shouldn't the build system then make the installation of those legacy file conditional on the version of libcloudproviders found on the system?

[mbiebl]

I.e the build system should do either the one or the other, but not both.

[werdahias]

agreed, this could be done by a

 if(cloudproviders FOUND) && version >= 0.3.3 
...

in Cmakelists.txt (paraphrasing the syntax)

[Thesola10]

idk if it's just that, I'm using the Flatpak and still see duplicate shares.