avoid detecting permissions to be invalid on linux NTFS file system

[mgallien]

Close #7613

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-7745-c67aa8dde2ed198018cf3d41e91f9739fc2cf222-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate failed

Failed conditions
6 Security Hotspots
87 New Code Smells (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
2 New Bugs (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[mbiebl]

I'm getting

2025-01-10 15:44:55:888 [ info nextcloud.sync.engine /drone/src/src/libsync/syncengine.cpp:645 ]:↦      File system type for current sync folder: "fuseblk"

michael@mars:~$ findmnt /mnt/data 
TARGET    SOURCE          FSTYPE  OPTIONS
/mnt/data /dev/nvme0n1p11 fuseblk rw,relatime,user_id=0,group_id=0,allow_other,blksize=4096
michael@mars:~$ grep data /etc/fstab 
LABEL=Data      /mnt/data       ntfs-3g auto            0       0

[luk-brue]

I built this branch from source on Linux Mint 21.3 Cinnamon and tested it with some folders on NTFS partitions (different partition than the OS). It works sometimes, which was great! But then it stops working and does not sync new files. Either it is stuck in Offline or it is stuck in "preparing sync..." for hours and nothing happens, even though new files are in the folder. Sometimes it also says "checking folder for new files..." The only solution to make sync work again on NTFS partitions is to remove the accounts and re-add them, then it works sometimes. However, syncing a folder on the same partition as the OS, normal ext4 filesystem, is working fine.

Also weird, When I add an account, I have to authenticate once when I add it and once more when I reboot the machine for the first time afterwards.
I don't know if this is on my side (Qt communicating with keyring) or the client side.

Built with Qt 6.8.2.
I hope this little experience review will help in the developing process, you are doing an awesome job! If you have more questions, I can try to answer them.

[nilsding]

Also weird, When I add an account, I have to authenticate once when I add it and once more when I reboot the machine for the first time afterwards.

this should be fixed with #7768 which was merged after this PR was created (and this branch is currently out-of-date). Should be fine on latest master...

[mgallien]

still on my TODO list
hoping to have time soon to finish it

[Kleisli]

@mgallien is there anything I could do to support you fixing this bug?
Should I test the AppImage from Jan 10? Or do you need Debug-Logs?

[claucambra]

I approved too fast

Looking into the QStorageInfo documentation here: https://doc.qt.io/qt-6/qstorageinfo.html#fileSystemType

It seems having the NTFS name returned for an NTFS filesystem is dependable on Windows and not on Linux where it can be ntfs-3g or fuseblk, backing up @mbiebl findings

[mgallien]

should now works fine
I tested it with fuse ntfs-3g driver on a recent Debian sid

no longer a maintainer

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-7745.zip

Digest: sha256:5e47f6614c4baec400119a19c04904bca154a5cc9621e44e5759556a6607a0fc

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Quality Gate failed

Failed conditions
2 New Bugs (required ≤ 0)
193 New Code Smells (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[mgallien]

/backport to stable-4.0