macOS File Provider Context Menu Fixes

[phipz]

How to use GitHub

• Please use the 👍 reaction to show that you are interested into the same feature.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Feature request

Which Nextcloud Version are you currently using: (see administration page)
Desktop 4.0.1 MacOS

Is your feature request related to a problem? Please describe.
VFS on MacOS improved greatly with 4.0 in terms of functionality. It's UI representation is sometimes still confusing and not consistent with iCloud Drive.

Describe the solution you'd like

1. Add a symbol next to all files that are always kept downloaded, analogous to iCloud

2. Add a context menu option to "Show in Downloaded Folder", analogous to iCloud

3. Hide the context menu option to "keep file downloaded" for children of folders that are always kept downloaded (they are already kept downloaded and clicking does not change anything)

4. Hide the context menu option to "Remove Download" for children of folders that are always kept downloaded (throws an error message "cannot be evicted", correctly as parent is "always downloaded")

Describe alternatives you've considered
N/A

Additional context
See screenshots referring to each sugggested solution.

1:

2:

3+4:

[i2h3]

While this makes sense, it is not our goal to completely copy iCloud Drive. Further, our technical options are limited to the offering of the file provider framework by Apple and we can influence the appearance in the first-party user interface (Finder) into which we integrate only in limited ways.

I will comment on this in detail later.

[phipz]

Thanks very much for taking this on, @i2h3!

As another example, the third-party app Mountainduck integrates via File Provider and adds said sync symbols, for easy distinguishing between always kept offline files (dark green) and temporarily cached files (light green). Here is their documentation with explanation of symbols and integration.

[i2h3]

1. We indeed do not have an indicator, as I just saw.
2. I was unfamiliar with this yet (even though I use iCloud, too). Just for reference: Selecting this feature will reveal the topmost item in the hierarchy which is marked as "keep downloaded".
3. This should be easy to implement by modifying the query used for controlling visibility. This is related to another bug, by the way: [Bug]: Keeping File Provider Items Available Offline Does Not Apply Recursively #9057
4. Same. An additional subquery on the content policy property of the item should do the trick.