Release 3.17.4

[camilasan]

📝 TO DO

• ⚠️ checks that the milestone associated with the release has no outstanding pending work to be done
• ⬆️ Bump VERSION.cmake to 3.17.4 in the corresponding stable branch
• 🏷️ Create tag from corresponding stable branch on the commit introducing the version bump

$ git checkout stable-3.17
$ git pull
$ git tag -s -m "Release 3.17.4" v3.17.4 
$ git push origin --tags

git remote add releases git@github.com:nextcloud-releases/desktop.git
git fetch origin v3.17.4
git push releases v3.17.4

• 🏷️ Create tag from corresponding stable branch in client-building.

$ git checkout stable-3.17
$ git pull
$ git tag -s -m "Release 3.17.4" v3.17.4
$ git push origin --tags

• 🏭 Trigger the builds on brander and wait for them to succeed:
  • 🐧 Linux
  • 🍎 Mac OS classic
  • 🍎 Mac OS vfs
  • 🚪 Windows MSI
• 🧪 Execute the bugfix release test plan for each build:
  • 🐧 Linux
    • update from last release candidate (meaning that you have an existing account configured with the release candidate and use it with the official AppImage)
      • upload/download/check activity/check integration to file browser
      • check cpu usage during sync
      • tray menu interaction
      • test Talk notifications (receive notification, reply to a message)
    • fresh installation
      • configure a new account
      • upload/download/check activity/check integration to file browser
      • check cpu usage during sync
      • tray menu interaction
      • test Talk notifications (receive notification, reply to a message)
      • check cpu usage during sync
      • test important new fixes in this release
  • 🍎 Mac OS
    ⚠️ Check the logs for:
    • Sharing succeeded: it needs to be signed similarly to .pkg file and uploaded everywhere.
    • Get the link after the last mention of Sharing succeeded to download the delta update file (.tbz) (required for automated upgrade).
    • be careful macOS VFS packages are wrongly named and should follow this pattern: Nextcloud-x.y.z-macOS-vfs.pkg
    • update from last release candidate (meaning that you have an existing account configured with the release candidate and upgrade the installation via installer)
      • upload/download/check activity/check integration to file browser
      • check cpu usage during sync
      • tray menu interaction
      • test Talk notifications (receive notification, reply to a message)
    • fresh installation
      • configure a new account using VFS sync
        • upload/download/check activity/check integration to file browser
        • check cpu usage during sync
        • tray menu interaction
        • test Talk notifications (receive notification, reply to a message)
        • check cpu usage during sync
      • test important new fixes in this release
      • configure a new account using selective sync
        • upload/download/check activity/check integration to file browser
        • check cpu usage during sync
        • tray menu interaction
        • test Talk notifications (receive notification, reply to a message)
        • check cpu usage during sync
  • 🚪 Windows MSI
    • update from last release candidate (meaning that you have an existing account configured with the release candidate and upgrade the installation via installer)
      • upload/download/check activity/check integration to file browser
      • check cpu usage during sync
      • tray menu interaction
      • test Talk notifications (receive notification, reply to a message)
    • fresh installation
      • configure a new account using VFS sync
        • upload/download/check activity/check integration to file browser
        • check cpu usage during sync
        • tray menu interaction
        • test Talk notifications (receive notification, reply to a message)
        • check cpu usage during sync
      • test important new fixes in this release
      • configure a new account using selective sync
        • upload/download/check activity/check integration to file browser
        • check cpu usage during sync
        • tray menu interaction
        • test Talk notifications (receive notification, reply to a message)
        • check cpu usage during sync
• 🗝️ Sign binaries (ssh -P 2200 to signing VM, then, cat how-to-sign, then scp -P 2200 to download signatures)
• 📖 Create draft pre-release and release notes (click on Generate release notes) at:
  • nextcloud/desktop/releases
    ⚠️ Only add the release notes. Do not upload the binaries to nextcloud/desktop/releases.
  • nextcloud-releases/desktop/releases (copy the changelog from nextcloud/desktop/releases)
• 📦 Upload binaries to:
  • The draft pre-release at nextcloud-releases/desktop/releases
  • download.nextcloud.com in the user home directory (so still private)
• 🚀 Publish the draft pre-releases created previously at:
  • nextcloud/desktop/releases
    ⚠️ No binaries on this release page.
  • nextcloud-releases/desktop/releases
  • Run the publish_desktop.sh script on download.nextcloud.com so that the binaries appear at download.nextcloud.com/desktop/releases
  • 🛎️ Notify Marketing that the release is ready.
  • Ask sysadmin to update the .htaccess such that latest alias point toward the new release (for example https://download.nextcloud.com/desktop/releases/Windows/latest)
• Close the milestone for 3.17.4 (make sure every merged PR is included)
• Create the milestone for X.Y.(Z+1) (make sure every merged PR is included)
• 🆙 Change the values of $stableReleaseDate and $stableVersion in the updater server config to serve the release.
  ⚠️ For the mac update service: the sparkle:edSignature and length values are printed right after the last mention of Sharing succeeded in the brander build log. Replace the values "signature" and "length" under 'macos' in 'stable' with them.
• 🆙 Change the install-clients page to update the link to the latest release on Nextcloud website (direct modification via wordpress web ui)
• Ensure that desktop client links work on website and release packages are downloaded fine
• Also test links on portal and that release packages are downloaded fine