fix: Remove unneeded PDF.js web files from release #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danxuliu
commented
Oct 1, 2025
danxuliu
commented
- The example PDF is not used so it unnecessarily increases the package size of the PDF viewer app in almost 1MB
- The "templates/viewer.php" acts as the "viewer.html" included in the PDF.js package, so it is not needed either
|
/backport to stable32 |
|
/backport to stable31 |
szaimen
approved these changes
Oct 1, 2025
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
nickvergessen
approved these changes
Oct 1, 2025
- The example PDF is not used so it unnecessarily increases the package size of the PDF viewer app in almost 1MB - The "templates/viewer.php" acts as the "viewer.html" included in the PDF.js package, so it is not needed either Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
remove-unneeded-pdfjs-web-files-from-release
branch
from
305d072 to
68bfdba
Compare
This was referenced Oct 1, 2025
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.