Improve telemetry error handling with specific server feedback

Rikdekker · claude · Rikdekker · commit 1837ad61d683 · 2026-04-12T14:39:39.000+02:00
- Add sendReportWithDetails() to TelemetryService for detailed error info
- Show NcNoteCard with specific error message after sending report
- Add translations for telemetry feedback messages (en/nl/de/fr)

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/l10n/de.js b/l10n/de.js
@@ -823,5 +823,9 @@ OC.L10N.register('formvox', {
   "Your organization (optional)": "Ihre Organisation (optional)",
   "View subscription options": "Abonnementoptionen anzeigen",
   "Your FormVox installation has exceeded the free tier limits (25 forms or 50 users). Consider subscribing to support ongoing development.": "Ihre FormVox-Installation hat die kostenlosen Grenzen \u00fcberschritten (25 Formulare oder 50 Benutzer). Erw\u00e4gen Sie ein Abonnement, um die weitere Entwicklung zu unterst\u00fctzen.",
-  "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Ihr FormVox-Abonnementschl\u00fcssel ist ung\u00fcltig oder abgelaufen. Erneuern Sie ihn, um weiterhin Support zu erhalten."
+  "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Ihr FormVox-Abonnementschl\u00fcssel ist ung\u00fcltig oder abgelaufen. Erneuern Sie ihn, um weiterhin Support zu erhalten.",
+  "Report sent successfully": "Bericht erfolgreich gesendet",
+  "The telemetry server returned an error:": "Der Telemetrie-Server hat einen Fehler zur\u00fcckgegeben:",
+  "Could not reach the telemetry server. Please try again later.": "Der Telemetrie-Server ist nicht erreichbar. Bitte versuchen Sie es sp\u00e4ter erneut.",
+  "Failed to send report": "Bericht konnte nicht gesendet werden"
 }, 'nplurals=2; plural=(n != 1);');
diff --git a/l10n/de.json b/l10n/de.json
@@ -827,7 +827,11 @@
     "Your organization (optional)": "Ihre Organisation (optional)",
     "View subscription options": "Abonnementoptionen anzeigen",
     "Your FormVox installation has exceeded the free tier limits (25 forms or 50 users). Consider subscribing to support ongoing development.": "Ihre FormVox-Installation hat die kostenlosen Grenzen überschritten (25 Formulare oder 50 Benutzer). Erwägen Sie ein Abonnement, um die weitere Entwicklung zu unterstützen.",
-    "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Ihr FormVox-Abonnementschlüssel ist ungültig oder abgelaufen. Erneuern Sie ihn, um weiterhin Support zu erhalten."
+    "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Ihr FormVox-Abonnementschlüssel ist ungültig oder abgelaufen. Erneuern Sie ihn, um weiterhin Support zu erhalten.",
+    "Report sent successfully": "Bericht erfolgreich gesendet",
+    "The telemetry server returned an error:": "Der Telemetrie-Server hat einen Fehler zurückgegeben:",
+    "Could not reach the telemetry server. Please try again later.": "Der Telemetrie-Server ist nicht erreichbar. Bitte versuchen Sie es später erneut.",
+    "Failed to send report": "Bericht konnte nicht gesendet werden"
   },
   "pluralForm": "nplurals=2; plural=(n != 1);"
 }
diff --git a/l10n/en.js b/l10n/en.js
@@ -823,5 +823,9 @@ OC.L10N.register('formvox', {
   "1000+ users": "1000+ users",
   "\u20ac19/year": "\u20ac19/year",
   "\u20ac59/year": "\u20ac59/year",
-  "\u20ac139/year": "\u20ac139/year"
+  "\u20ac139/year": "\u20ac139/year",
+  "Report sent successfully": "Report sent successfully",
+  "The telemetry server returned an error:": "The telemetry server returned an error:",
+  "Could not reach the telemetry server. Please try again later.": "Could not reach the telemetry server. Please try again later.",
+  "Failed to send report": "Failed to send report"
 }, 'nplurals=2; plural=(n != 1);');
diff --git a/l10n/en.json b/l10n/en.json
@@ -827,7 +827,11 @@
     "1000+ users": "1000+ users",
     "€19/year": "€19/year",
     "€59/year": "€59/year",
-    "€139/year": "€139/year"
+    "€139/year": "€139/year",
+    "Report sent successfully": "Report sent successfully",
+    "The telemetry server returned an error:": "The telemetry server returned an error:",
+    "Could not reach the telemetry server. Please try again later.": "Could not reach the telemetry server. Please try again later.",
+    "Failed to send report": "Failed to send report"
   },
   "pluralForm": "nplurals=2; plural=(n != 1);"
 }
diff --git a/l10n/fr.js b/l10n/fr.js
@@ -823,5 +823,9 @@ OC.L10N.register('formvox', {
   "Your organization (optional)": "Votre organisation (optionnel)",
   "View subscription options": "Voir les options d'abonnement",
   "Your FormVox installation has exceeded the free tier limits (25 forms or 50 users). Consider subscribing to support ongoing development.": "Votre installation FormVox a d\u00e9pass\u00e9 les limites gratuites (25 formulaires ou 50 utilisateurs). Envisagez de vous abonner pour soutenir le d\u00e9veloppement continu.",
-  "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Votre cl\u00e9 d'abonnement FormVox est invalide ou expir\u00e9e. Renouvelez-la pour continuer \u00e0 b\u00e9n\u00e9ficier du support."
+  "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Votre cl\u00e9 d'abonnement FormVox est invalide ou expir\u00e9e. Renouvelez-la pour continuer \u00e0 b\u00e9n\u00e9ficier du support.",
+  "Report sent successfully": "Rapport envoy\u00e9 avec succ\u00e8s",
+  "The telemetry server returned an error:": "Le serveur de t\u00e9l\u00e9m\u00e9trie a renvoy\u00e9 une erreur :",
+  "Could not reach the telemetry server. Please try again later.": "Impossible de joindre le serveur de t\u00e9l\u00e9m\u00e9trie. Veuillez r\u00e9essayer plus tard.",
+  "Failed to send report": "\u00c9chec de l'envoi du rapport"
 }, 'nplurals=2; plural=(n != 1);');
diff --git a/l10n/fr.json b/l10n/fr.json
@@ -827,7 +827,11 @@
     "Your organization (optional)": "Votre organisation (optionnel)",
     "View subscription options": "Voir les options d'abonnement",
     "Your FormVox installation has exceeded the free tier limits (25 forms or 50 users). Consider subscribing to support ongoing development.": "Votre installation FormVox a dépassé les limites gratuites (25 formulaires ou 50 utilisateurs). Envisagez de vous abonner pour soutenir le développement continu.",
-    "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Votre clé d'abonnement FormVox est invalide ou expirée. Renouvelez-la pour continuer à bénéficier du support."
+    "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Votre clé d'abonnement FormVox est invalide ou expirée. Renouvelez-la pour continuer à bénéficier du support.",
+    "Report sent successfully": "Rapport envoyé avec succès",
+    "The telemetry server returned an error:": "Le serveur de télémétrie a renvoyé une erreur :",
+    "Could not reach the telemetry server. Please try again later.": "Impossible de joindre le serveur de télémétrie. Veuillez réessayer plus tard.",
+    "Failed to send report": "Échec de l'envoi du rapport"
   },
   "pluralForm": "nplurals=2; plural=(n != 1);"
 }
diff --git a/l10n/nl.js b/l10n/nl.js
@@ -823,5 +823,9 @@ OC.L10N.register('formvox', {
   "Your organization (optional)": "Uw organisatie (optioneel)",
   "View subscription options": "Abonnementsopties bekijken",
   "Your FormVox installation has exceeded the free tier limits (25 forms or 50 users). Consider subscribing to support ongoing development.": "Uw FormVox-installatie heeft de gratis limieten overschreden (25 formulieren of 50 gebruikers). Overweeg een abonnement om de verdere ontwikkeling te ondersteunen.",
-  "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Uw FormVox-abonnementssleutel is ongeldig of verlopen. Verleng om ondersteuning te blijven ontvangen."
+  "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Uw FormVox-abonnementssleutel is ongeldig of verlopen. Verleng om ondersteuning te blijven ontvangen.",
+  "Report sent successfully": "Rapport succesvol verstuurd",
+  "The telemetry server returned an error:": "De telemetrieserver gaf een fout:",
+  "Could not reach the telemetry server. Please try again later.": "Kan de telemetrieserver niet bereiken. Probeer het later opnieuw.",
+  "Failed to send report": "Rapport versturen mislukt"
 }, 'nplurals=2; plural=(n != 1);');
diff --git a/l10n/nl.json b/l10n/nl.json
@@ -827,7 +827,11 @@
     "Your organization (optional)": "Uw organisatie (optioneel)",
     "View subscription options": "Abonnementsopties bekijken",
     "Your FormVox installation has exceeded the free tier limits (25 forms or 50 users). Consider subscribing to support ongoing development.": "Uw FormVox-installatie heeft de gratis limieten overschreden (25 formulieren of 50 gebruikers). Overweeg een abonnement om de verdere ontwikkeling te ondersteunen.",
-    "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Uw FormVox-abonnementssleutel is ongeldig of verlopen. Verleng om ondersteuning te blijven ontvangen."
+    "Your FormVox subscription key is invalid or expired. Please renew to continue receiving support.": "Uw FormVox-abonnementssleutel is ongeldig of verlopen. Verleng om ondersteuning te blijven ontvangen.",
+    "Report sent successfully": "Rapport succesvol verstuurd",
+    "The telemetry server returned an error:": "De telemetrieserver gaf een fout:",
+    "Could not reach the telemetry server. Please try again later.": "Kan de telemetrieserver niet bereiken. Probeer het later opnieuw.",
+    "Failed to send report": "Rapport versturen mislukt"
   },
   "pluralForm": "nplurals=2; plural=(n != 1);"
 }
diff --git a/lib/Controller/StatisticsController.php b/lib/Controller/StatisticsController.php
@@ -67,15 +67,17 @@ public function sendTelemetry(): DataResponse
             $this->telemetryService->setEnabled(true);
         }
 
-        $success = $this->telemetryService->sendReport();
+        $result = $this->telemetryService->sendReportWithDetails();
 
         // Restore original state
         if (!$wasEnabled) {
             $this->telemetryService->setEnabled(false);
         }
 
         return new DataResponse([
-            'success' => $success,
+            'success' => $result['success'],
+            'reason' => $result['reason'] ?? null,
+            'message' => $result['message'] ?? null,
             'lastReport' => $this->telemetryService->getLastReportTime(),
         ]);
     }
diff --git a/lib/Service/TelemetryService.php b/lib/Service/TelemetryService.php
@@ -73,10 +73,18 @@ public function getTelemetryUrl(): string
      * @return bool Success status
      */
     public function sendReport(): bool
+    {
+        return $this->sendReportWithDetails()['success'];
+    }
+
+    /**
+     * Send telemetry report to the server with detailed error info
+     * @return array{success: bool, reason?: string, message?: string}
+     */
+    public function sendReportWithDetails(): array
     {
         if (!$this->isEnabled()) {
-            $this->logger->debug('TelemetryService: Telemetry is disabled, skipping report');
-            return false;
+            return ['success' => false, 'reason' => 'disabled'];
         }
 
         try {
@@ -107,16 +115,23 @@ public function sendReport(): bool
                     (string)time()
                 );
 
-                return true;
+                return ['success' => true];
             }
 
-            // Silent fail - server may not be ready yet
-            // TODO v1.3: Add proper error logging once server is stable
-            return false;
+            return ['success' => false, 'reason' => 'server_error', 'message' => 'HTTP ' . $statusCode];
         } catch (\Exception $e) {
-            // Silent fail - server may not be available
-            // TODO v1.3: Add proper error logging once server is stable
-            return false;
+            $message = $e->getMessage();
+            if (method_exists($e, 'getResponse') && $e->getResponse() !== null) {
+                $body = (string) $e->getResponse()->getBody();
+                $json = json_decode($body, true);
+                if (isset($json['error'])) {
+                    $message = $json['error'];
+                } elseif (!empty($body) && strlen($body) < 200) {
+                    $message = $body;
+                }
+            }
+            $this->logger->warning('TelemetryService: Failed to send report: ' . $message);
+            return ['success' => false, 'reason' => 'error', 'message' => $message];
         }
     }
 
diff --git a/src/components/SupportSettings.vue b/src/components/SupportSettings.vue
@@ -228,6 +228,9 @@
 							{{ sendingTelemetry ? t('Sending...') : t('Send report now') }}
 						</NcButton>
 					</NcNoteCard>
+					<NcNoteCard v-if="telemetryMessage" :type="telemetryMessageType" class="telemetry-result">
+						{{ telemetryMessage }}
+					</NcNoteCard>
 				</div>
 
 				<div class="telemetry-details">
@@ -295,6 +298,8 @@ export default {
 			telemetryEnabled: this.initialTelemetryEnabled,
 			telemetryLastReport: this.initialTelemetryLastReport,
 			sendingTelemetry: false,
+			telemetryMessage: '',
+			telemetryMessageType: 'success',
 			message: '',
 			messageType: 'success',
 		}
@@ -409,11 +414,32 @@ export default {
 
 		async sendTelemetryNow() {
 			this.sendingTelemetry = true
+			this.telemetryMessage = ''
 			try {
-				await axios.post(generateUrl('/apps/formvox/api/statistics/telemetry/send'))
-				this.telemetryLastReport = Math.floor(Date.now() / 1000)
+				const response = await axios.post(generateUrl('/apps/formvox/api/statistics/telemetry/send'))
+				const data = response.data
+				if (data.success) {
+					this.telemetryLastReport = Math.floor(Date.now() / 1000)
+					this.telemetryMessage = this.t('Report sent successfully')
+					this.telemetryMessageType = 'success'
+				} else if (data.reason === 'server_error' || data.reason === 'error') {
+					const serverMsg = data.message || ''
+					if (serverMsg.startsWith('HTTP ') || serverMsg.includes('error')) {
+						this.telemetryMessage = this.t('The telemetry server returned an error:') + ' ' + serverMsg
+					} else if (serverMsg.includes('cURL') || serverMsg.includes('connect') || serverMsg.includes('timeout') || serverMsg.includes('resolve')) {
+						this.telemetryMessage = this.t('Could not reach the telemetry server. Please try again later.')
+					} else {
+						this.telemetryMessage = this.t('Failed to send report') + (serverMsg ? ': ' + serverMsg : '')
+					}
+					this.telemetryMessageType = 'error'
+				} else {
+					this.telemetryMessage = this.t('Failed to send report')
+					this.telemetryMessageType = 'error'
+				}
 			} catch (error) {
 				console.error('Failed to send telemetry:', error)
+				this.telemetryMessage = this.t('Could not reach the telemetry server. Please try again later.')
+				this.telemetryMessageType = 'error'
 			} finally {
 				this.sendingTelemetry = false
 			}

Original file line number	Diff line number	Diff line change
`@@ -67,15 +67,17 @@ public function sendTelemetry(): DataResponse`
`67`	`67`	`$this->telemetryService->setEnabled(true);`
`68`	`68`	`}`
`69`	`69`
`70`		`- $success = $this->telemetryService->sendReport();`
	`70`	`+ $result = $this->telemetryService->sendReportWithDetails();`
`71`	`71`
`72`	`72`	`// Restore original state`
`73`	`73`	`if (!$wasEnabled) {`
`74`	`74`	`$this->telemetryService->setEnabled(false);`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`return new DataResponse([`
`78`		`- 'success' => $success,`
	`78`	`+ 'success' => $result['success'],`
	`79`	`+ 'reason' => $result['reason'] ?? null,`
	`80`	`+ 'message' => $result['message'] ?? null,`
`79`	`81`	`'lastReport' => $this->telemetryService->getLastReportTime(),`
`80`	`82`	`]);`
`81`	`83`	`}`