Skip to content

Commit be19f97

Browse files
authored
Merge pull request #2906 from nextcloud/backport/2904/stable28
[stable28] Even more acl ux fixes
2 parents a137601 + 4fe1cff commit be19f97

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

β€Žappinfo/info.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Folders can be configured from *Group folders* in the admin settings.
1010
After a folder is created, the admin can give access to the folder to one or more groups, control their write/sharing permissions and assign a quota for the folder.
1111
1212
Note: Encrypting the contents of group folders is currently not supported.]]></description>
13-
<version>16.0.5</version>
13+
<version>16.0.6</version>
1414
<licence>agpl</licence>
1515
<author>Robin Appelman</author>
1616
<namespace>GroupFolders</namespace>

β€Žsrc/client.js

+4
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,10 @@ class AclDavService {
228228
inheritedAclsById[id] = acl
229229
if (aclsById[id] == null) {
230230
aclsById[id] = acl
231+
232+
aclsById[id].inheritedMask = acl.mask
233+
aclsById[id].inheritedPermissions = acl.permissions
234+
aclsById[id].mask = 0
231235
} else {
232236
aclsById[id].inheritedMask = acl.mask
233237
aclsById[id].inheritedPermissions = acl.permissions

β€Žsrc/components/SharingSidebarView.vue

+2-3
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,10 @@
133133
</template>
134134
{{ t('groupfolders', 'Add advanced permission rule') }}
135135
</NcButton>
136-
<NcSelect v-if="isAdmin && !loading"
137-
v-show="showAclCreate"
136+
<NcSelect v-if="isAdmin && !loading && showAclCreate"
138137
ref="select"
139138
v-model="value"
140139
:options="options"
141-
:clear-search-on-select="true"
142140
:loading="isSearching"
143141
:filterable="false"
144142
:placeholder="t('groupfolders', 'Select a user or group')"
@@ -312,6 +310,7 @@ export default {
312310
})
313311
},
314312
createAcl(option) {
313+
this.value = null
315314
const rule = new Rule()
316315
rule.fromValues(option.type, option.id, option.displayname, 0b00000, 0b11111)
317316
this.list.push(rule)

0 commit comments

Comments
Β (0)