fix: Extract a template for the nextcloud container (app/cronjob) #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kirchner <[email protected]>
MartinKirchner
force-pushed
the
feature/containerTemplate
branch
from
998259a to
d5fa9ce
Compare
wrenix
reviewed
Mar 18, 2025
| volumeMounts: | ||
| {{- include "nextcloud.volumeMounts" . | trim | nindent 12 }} | ||
| {{- $containerName := printf "%s-cron" .Chart.Name }} | ||
| {{- include "nextcloud.container" ( dict "containerName" $containerName "securityContext" .Values.cronjob.securityContext "rootContext" $ "context" .Values.cronjob ) | nindent 8 }} |
There was a problem hiding this comment.
why we need securityContext, if we has already context ?
There was a problem hiding this comment.
oh i see -> do you like to move the values.yaml (and make a breaking change / bump to major)?
remembers me on #379 (comment)
There was a problem hiding this comment.
@wrenix If it's okay for you I'd rather remove the securityContext for the app container (as it is deprecated anyhow).
As for the major version - I hope you remember that my actual goal is to move the cron sidecar to a Kubernetes CronJob.
- Do you think the Kubernetes Cronjob has a chance to make it's way into this chart?
- If so, does it make sense to combine these two changes in one new major version?
- What do you propose on how to proceed?
There was a problem hiding this comment.
@wrenix Any answer to my questions?
wrenix
requested changes
Mar 18, 2025
| - name: {{ .containerName }} | ||
| image: {{ include "nextcloud.image" .rootContext }} | ||
| imagePullPolicy: {{ .rootContext.Values.image.pullPolicy }} | ||
| {{- if .context.command }} |
wrenix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Use a helper template to define the containers for app/cronjob.
Benefits
Possible drawbacks
None known.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.