fix: Cannot guess groupMemberAssocAttr from gid before creating group

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Author: come-nc

lib/LDAPConnect.php

@@ -122,6 +122,10 @@ public function getDisplayNameAttribute(): string {
 		return $this->ldapConfig->ldapUserDisplayName;
 	}
 
+	public function getGroupMemberAssocAttribute(): string {
+		return strtolower($this->ldapConfig->ldapGroupMemberAssocAttr);
+	}
+
 	public function groupsEnabled(): bool {
 		$filter = trim((string)$this->ldapConfig->ldapGroupFilter);
 		$gAssoc = trim((string)$this->ldapConfig->ldapGroupMemberAssocAttr);

lib/LDAPGroupManager.php

@@ -53,7 +53,7 @@ public function createGroup($gid): ?string {
 		 * on passing an already inserted [ug]id, which we do not have at this point.
 		 */
 
-		$newGroupEntry = $this->buildNewEntry($gid);
+		$newGroupEntry = $this->buildNewEntry($gid, $this->ldapConnect->getGroupMemberAssocAttribute());
 		$connection = $this->ldapConnect->getLDAPConnection();
 		$newGroupDN = "cn=$gid," . $this->ldapConnect->getLDAPBaseGroups()[0];
 		$newGroupDN = $this->ldapProvider->sanitizeDN([$newGroupDN])[0];
@@ -178,12 +178,11 @@ public function isLDAPGroup($gid): bool {
 		}
 	}
 
-	private function buildNewEntry(string $gid): array {
+	private function buildNewEntry(string $gid, string $attribute): array {
 		$entry = [
 			'objectClass' => [],
 			'cn' => $gid,
 		];
-		$attribute = strtolower($this->ldapProvider->getLDAPGroupMemberAssoc($gid));
 		switch ($attribute) {
 			case 'memberuid':
 			case 'gidnumber':