fix: change status code from 404 to 204 for missing avatars

Switching the response code from 404 to 204 improves compatibility with security appliances like CrowdSec. Since avatar lookups (including external sources) can validly result in a non-existing avatar. Signed-off-by: Daniel Kesselberg <[email protected]>
nextcloud · Feb 14, 2025 · a7b4fab · a7b4fab
1 parent 871615e
commit a7b4fab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/Controller/AvatarsController.php b/lib/Controller/AvatarsController.php
@@ -67,7 +67,7 @@ public function url(string $email): JSONResponse {
 		$avatar = $this->avatarService->getAvatar($email, $this->uid);
 		if (is_null($avatar)) {
 			// No avatar found
-			$response = new JSONResponse([], Http::STATUS_NOT_FOUND);
+			$response = new JSONResponse([], Http::STATUS_NO_CONTENT);
 
 			// Debounce this a bit
 			// (cache for one day)

diff --git a/tests/Unit/Controller/AvatarControllerTest.php b/tests/Unit/Controller/AvatarControllerTest.php
@@ -95,7 +95,7 @@ public function testGetUrlNoAvatarFound() {
 
 		$resp = $this->controller->url($email);
 
-		$expected = new JSONResponse([], Http::STATUS_NOT_FOUND);
+		$expected = new JSONResponse([], Http::STATUS_NO_CONTENT);
 		$expected->cacheFor(24 * 60 * 60, false, true);
 		$this->assertEquals($expected, $resp);
 	}