Merge pull request #10694 from nextcloud/bug/noid/avatar-204

fix: change status code from 404 to 204 for missing avatars
nextcloud · Feb 14, 2025 · aa451b7 · aa451b7
2 parents bcd5239 + 92bf4ef
commit aa451b7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/Controller/AvatarsController.php b/lib/Controller/AvatarsController.php
@@ -54,7 +54,7 @@ public function url(string $email): JSONResponse {
 		$avatar = $this->avatarService->getAvatar($email, $this->uid);
 		if (is_null($avatar)) {
 			// No avatar found
-			$response = new JSONResponse([], Http::STATUS_NOT_FOUND);
+			$response = new JSONResponse([], Http::STATUS_NO_CONTENT);
 
 			// Debounce this a bit
 			// (cache for one day)

diff --git a/tests/Unit/Controller/AvatarControllerTest.php b/tests/Unit/Controller/AvatarControllerTest.php
@@ -78,7 +78,7 @@ public function testGetUrlNoAvatarFound() {
 
 		$resp = $this->controller->url($email);
 
-		$expected = new JSONResponse([], Http::STATUS_NOT_FOUND);
+		$expected = new JSONResponse([], Http::STATUS_NO_CONTENT);
 		$expected->cacheFor(24 * 60 * 60, false, true);
 		$this->assertEquals($expected, $resp);
 	}