fix!: remove mail transport php-mail

Signed-off-by: Daniel Kesselberg <[email protected]>

Author: kesselb

doc/admin.md

@@ -57,6 +57,10 @@ Configure how often Mail keeps users' mailboxes updated in the background in sec
 ```
 
 ### Use php-mail for sending mail
+
+> [!WARNING]
+> Support for using php-mail will be removed with Mail 4.4
+
 You can use the php-mail function to send mails. This is needed for some webhosters (1&1 (1und1)):
 ```php
 'app.mail.transport' => 'php-mail'

lib/SMTP/SmtpClientFactory.php

@@ -10,7 +10,6 @@
 namespace OCA\Mail\SMTP;
 
 use Horde_Mail_Transport;
-use Horde_Mail_Transport_Mail;
 use Horde_Mail_Transport_Smtphorde;
 use Horde_Smtp_Password_Xoauth2;
 use OCA\Mail\Account;
@@ -43,10 +42,6 @@ public function __construct(IConfig $config,
 	 */
 	public function create(Account $account): Horde_Mail_Transport {
 		$mailAccount = $account->getMailAccount();
-		$transport = $this->config->getSystemValue('app.mail.transport', 'smtp');
-		if ($transport === 'php-mail') {
-			return new Horde_Mail_Transport_Mail();
-		}
 
 		$decryptedPassword = null;
 		if ($mailAccount->getOutboundPassword() !== null) {

lib/SystemConfig.php

@@ -10,7 +10,6 @@
 namespace OCA\Mail\Tests\Unit\Smtp;
 
 use ChristophWurst\Nextcloud\Testing\TestCase;
-use Horde_Mail_Transport_Mail;
 use Horde_Mail_Transport_Smtphorde;
 use OCA\Mail\Account;
 use OCA\Mail\Db\MailAccount;
@@ -43,19 +42,6 @@ protected function setUp(): void {
 		$this->factory = new SmtpClientFactory($this->config, $this->crypto, $this->hostNameFactory);
 	}
 
-	public function testPhpMailTransport() {
-		$account = $this->createMock(Account::class);
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with('app.mail.transport', 'smtp')
-			->willReturn('php-mail');
-
-		$transport = $this->factory->create($account);
-
-		$this->assertNotNull($transport);
-		$this->assertInstanceOf(Horde_Mail_Transport_Mail::class, $transport);
-	}
-
 	public function testSmtpTransport() {
 		$mailAccount = new MailAccount([
 			'smtpHost' => 'smtp.domain.tld',