Skip to content

Commit b58e3ca

Browse files
committed
Merge branch 'fix-filters-for-null-passwords'
Signed-off-by: binsky <timo@binsky.org>
2 parents 9d62315 + 324bb15 commit b58e3ca

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

js/app/controllers/credential.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -478,12 +478,13 @@
478478
let postFiltered=[];
479479

480480
for (let i = 0; i < initialCredentials.length; i++) {
481-
const _credential = initialCredentials[i];
482-
const zxcvbn_result = zxcvbn(_credential.password);
481+
if (initialCredentials[i].password !== null) {
482+
const zxcvbn_result = zxcvbn(initialCredentials[i].password);
483483

484-
if(zxcvbn_result.score>=strength_min && zxcvbn_result.score<=strength_max){
485-
postFiltered.push(initialCredentials[i]);
486-
}
484+
if(zxcvbn_result.score>=strength_min && zxcvbn_result.score<=strength_max){
485+
postFiltered.push(initialCredentials[i]);
486+
}
487+
}
487488
}
488489
$scope.filtered_credentials=$scope.filterHidden(postFiltered);
489490
};
@@ -510,7 +511,7 @@
510511
for (let i = 0; i < initialCredentials.length; i++) {
511512
const _credential = initialCredentials[i];
512513

513-
if(_credential.compromised !== false){
514+
if(_credential.compromised !== false && _credential.compromised !== null){
514515
postFiltered.push(initialCredentials[i]);
515516
}
516517
}

0 commit comments

Comments
 (0)