Photos layout for link shares

[grenzverkehr]

It should be possible to present photos via a public photo link in the photo gallery view. This is important for everyone who values the presentation of their photos. Up to now only the files view can be shared publicly.
This was possible in the Gallery app: instead of "/s/name" (Files view), the URLs were then called "apps/gallery/s/name" (Gallery view).

[dsiminiuk]

Without the gallery view from a shared URL this plugin I don't see the value of this plugin. I may as well share the folder the regular way.

hint: The old Gallery app was good at this.

[skjnldsv]

@nickvergessen we need to add the redirect in server, right?

[nickvergessen]

Well the gallery way was wrong and one reason for starting new. It duplicated all the share controller logic into the app to have a second URL.

From my POV we should just make sure the photos app (same with other viewer) show on public shares.

[skjnldsv]

From my POV we should just make sure the photos app (same with other viewer) show on public shares.

Well, we have viewer on public page now, but not sure about having the photo view there 🤔
Thoughts @jancborchardt ?

[diamaunt]

I can't possibly emphasize this issue enough.
the photos is completely useless as it is -to me-, the entire reason for using it is to be able to share photo galleries with others.

Please fix this as soon as you can!

[diamaunt]

@nickvergessen the old gallery app may have been "wrong", but at least it worked.

I'd love to love photos, but right now, it's just broken my site.

[nickvergessen]

the photos is completely useless as it is

Way to motivate people... It might not cover your usecase (yet). But the new Photos/Album view is really helping me and also other people seem to like it.

the old gallery app may have been "wrong", but at least it worked.

Again, that is your usecase, not everyones. The Gallery used it's own endpoint, previews and logic, which even leads to security issues like showing all images of folders which are shared as "files drop" (upload only): https://nextcloud.com/security/advisory/?id=NC-SA-2019-012
So we had to get rid of the gallery and replace it with something new. We see that it is not covering all usecases yet, that where covered by the gallery app, but no one claims it does and no one is saying it's not going to change in the future.

Please fix this as soon as you can!

But maybe this is your time to shine @diamaunt with your empty github account to start contributing. See the readme how to get involved: https://github.com/nextcloud/photos#maintainers

And if you can't code, you can do other things that take away load from @skjnldsv so they can find the time to code stuff like this.

[Boki4d]

@nickvergessen
I can't code, but I really need the "gallery" view for the shared links. How can I help?

Guess I need to learn to code... :/

[diamaunt]

the photos is completely useless as it is

Way to motivate people...
But maybe this is your time to shine @diamaunt with your empty github account

@nickvergessen I see you're adept at motivating people yourself, by attacking THEM, instead of the issue, well done.

WELL, I'm certainly motivated.

In all fairness, I should have said "The Photos app is completely useless TO ME as it is. Would that have avoided your rant? (couldn't the time spent belittling me have been used more productively? I didn't degrade anyone, I didn't attack anyone, I didn't belittle anyone. Who do you think you are? Linus Torvalds?)

Please fix this as soon as you can!

no one is saying it's not going to change in the future.

And, if you'll note, that was exactly what I was asking for, I even said "please".

And if you can't code, you can do other things that take away load from @skjnldsv so they can find the time to code stuff like this.

Sure. what does @skjnldsv need?

[skjnldsv]

Sure. what does @skjnldsv need?

Time. Anyone willing to dive into this please do. Feel free to come and ask questions. We'll happily help anyone.

@diamaunt, @nickvergessen isn't the only one thinking what he wrote.
Please have a look at our code of conduct https://nextcloud.com/contribute/code-of-conduct/

In all fairness, I should have said "The Photos app is completely useless TO ME as it is. Would that have avoided your rant?

No, lors of people already discussed this here or in others issues, we do not want additional feedback stating if you dislike it or not. Please use Github's reaction feature as a way to advocate for already expressed feedback.

What you could have said that would have motivated people would be:

Hi! I'd also really like to see this feature implemented, what can I do to help?
Cheers
Michael

---

Thanks for your motivation, please keep that in mind next time you're participating to an open source project :)
Take care

[skjnldsv]

@Boki4d thank for your interest!

We could use a proper definition of what this issue is about. 😃
There is currently the files list view in folder sharing and the grid view.
The grid view is pretty close to what we already have in the albums view here in photos. What seems to be missing would be the timeline.

What would you like to see as a third sharing option then?
The album view with browsable folders or the unified view like the timeline? :)