fixup! fix(SecureView): hide disfunctional *download* files action

Author: blizzz

tests/features/bootstrap/RichDocumentsContext.php

@@ -30,6 +30,7 @@ class RichDocumentsContext implements Context {
 	private $fileIds = [];
 	/** @var array List of templates fetched for a given file type */
 	private $templates = [];
+	private array $directoryListing = [];
 
 	/** @BeforeScenario */
 	public function gatherContexts(BeforeScenarioScope $scope) {
@@ -75,6 +76,22 @@ public function userOpens($user, $file) {
 		Assert::assertNotEmpty($this->wopiToken);
 	}
 
+	/**
+	 * @When User :user lists :folder
+	 */
+	public function userListsDirectory($user, $folder) {
+		$this->directoryListing = [];
+		$this->serverContext->usingWebAsUser($user);
+		$this->directoryListing = $this->filesContext->listFolder($folder, 1, ['{http://nextcloud.org/ns}hide-download']);
+	}
+
+	/**
+	 * @When file :file :canOrCannot be downloaded
+	 */
+	public function fileCanOrCannotBeDownlowded(string $file, string $canOrCannot): void {
+		var_dump($this->directoryListing);
+	}
+
 	public function generateTokenWithApi($user, $fileId, ?string $shareToken = null, ?string $path = null, ?string $guestName = null) {
 		$this->serverContext->usingWebAsUser($user);
 		$this->serverContext->sendJSONRequest('POST', '/index.php/apps/richdocuments/token', [

tests/features/secure-view.feature

@@ -0,0 +1,18 @@
+Feature: API
+
+	Background:
+		Given user "user1" exists
+
+	Scenario: Open a file in a folder shared by link
+		Given as user "user1"
+		And User "user1" creates a folder "NewFolder"
+		And User "user1" uploads file "./../emptyTemplates/template.odt" to "/NewFolder/file.odt"
+		And as "user1" create a share with
+			| path      | /NewFolder |
+			| shareType | 3          |
+		When User "user1" lists "/NewFolder/"
+		Then file "file.odt" can be downloaded
+		And Using web as guest
+		#And a guest
+		#And checkFileInfo "UserId" matches "/Guest-/"
+		#Then download "is" prevented by Secure View

tests/run-integration.sh

@@ -50,12 +50,13 @@ PHPPIDB=$!
 
 $OCC config:app:set richdocuments wopi_url --value="http://localhost:9980"
 $OCC config:app:set richdocuments public_wopi_url --value="http://localhost:9980"
+$OCC config:app:set files watermark_enabled --value="yes"
+$OCC config:app:set files watermark_shareAll --value="yes"
 $OCC richdocuments:activate-config
 $OCC config:system:set allow_local_remote_servers --value true --type bool
 $OCC config:system:set gs.trustedHosts 0 --value="localhost:$PORT_SERVERA"
 $OCC config:system:set gs.trustedHosts 1 --value="localhost:$PORT_SERVERB"
 
-
 vendor/bin/behat $SCENARIO_TO_RUN
 RESULT=$?