Skip to content

Commit 11fe39f

Browse files
tcitworldnextcloud-command
authored andcommitted
fix(account menu): avoid having duplicate IDs for account menu entries without href links
When the account menu entry doesn't have an href property (for instance the entry added by First Run Wizard), the ID is duplicated between the list item and the <a> tag it contains Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
1 parent 1f4117a commit 11fe39f

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

core/src/components/AccountMenu/AccountMenuEntry.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
-->
55

66
<template>
7-
<NcListItem :id="href ? undefined : id"
7+
<NcListItem :id="href ? undefined : `${id}-account-menu-entry`"
88
:anchor-id="id"
99
:active="active"
1010
class="account-menu-entry"

dist/core-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-public-page-user-menu.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-public-page-user-menu.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)