fix(metadata): properly handle casting non-numeric values in search operations with custom metadata

If a metadata property is declared with a number type but the value provided are not numeric, it
logs "A non-numeric value encountered at
/var/www/nextcloud/apps/dav/lib/Files/FileSearchBackend.php#486" instead of throwing a proper error.
Now with a proper error we have the proper exception being thrown: InvalidArgumentException Invalid
property value for {http://nextcloud.org/ns}metadata-photos-original_date_time

Signed-off-by: Thomas Citharel <[email protected]>

Author: tcitworld

apps/dav/lib/Files/FileSearchBackend.php

@@ -482,7 +482,10 @@ private function castValue(SearchPropertyDefinition $property, $value) {
 			case SearchPropertyDefinition::DATATYPE_DECIMAL:
 			case SearchPropertyDefinition::DATATYPE_INTEGER:
 			case SearchPropertyDefinition::DATATYPE_NONNEGATIVE_INTEGER:
-				return 0 + $value;
+				if (is_numeric($value)) {
+					return 0 + $value;
+				}
+				throw new \Error("Value for numeric datatype is not numeric");
 			case SearchPropertyDefinition::DATATYPE_DATETIME:
 				if (is_numeric($value)) {
 					return max(0, 0 + $value);