Skip to content

Commit eb20746

Browse files
committed
fix(user_ldap): Correct label and placeholder usage
Signed-off-by: Louis Chmn <[email protected]>
1 parent cc39ae3 commit eb20746

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

apps/user_ldap/src/components/SettingsTabs/LoginTab.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<NcTextField
4242
v-model="testUsername"
4343
:helper-text="t('user_ldap', 'Attempts to receive a DN for the given login name and the current login filter')"
44-
:placeholder="t('user_ldap', 'Test Login name')"
44+
:label="t('user_ldap', 'Test Login name')"
4545
autocomplete="off" />
4646

4747
<NcButton

apps/user_ldap/src/components/SettingsTabs/ServerTab.vue

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,15 @@
3535
<NcTextField
3636
:model-value="ldapConfigProxy.ldapHost"
3737
:helper-text="t('user_ldap', 'You can omit the protocol, unless you require SSL. If so, start with ldaps://')"
38-
:placeholder="t('user_ldap', 'Host')"
38+
:label="t('user_ldap', 'Host')"
39+
:placeholder="t('user_ldap', 'ldaps://localhost')"
3940
autocomplete="off"
4041
@change="(event) => ldapConfigProxy.ldapHost = event.target.value" />
4142
<div class="ldap-wizard__server__host__port">
4243
<NcTextField
4344
:model-value="ldapConfigProxy.ldapPort"
45+
:label="t('user_ldap', 'Port')"
46+
:placeholder="t('user_ldap', '389')"
4447
type="number"
4548
autocomplete="off"
4649
@change="(event) => ldapConfigProxy.ldapPort = event.target.value" />
@@ -53,8 +56,9 @@
5356
<div class="ldap-wizard__server__line">
5457
<NcTextField
5558
v-model="localLdapAgentName"
56-
:helper-text="t('user_ldap', 'The DN of the client user with which the bind shall be done, e.g. uid=agent,dc=example,dc=com. For anonymous access, leave DN and Password empty.')"
57-
:placeholder="t('user_ldap', 'User DN')"
59+
:helper-text="t('user_ldap', 'The DN of the client user with which the bind shall be done. For anonymous access, leave DN and Password empty.')"
60+
:label="t('user_ldap', 'User DN')"
61+
:placeholder="t('user_ldap', 'uid=agent,dc=example,dc=com')"
5862
autocomplete="off" />
5963
</div>
6064

@@ -63,7 +67,7 @@
6367
v-model="localLdapAgentPassword"
6468
type="password"
6569
:helper-text="t('user_ldap', 'For anonymous access, leave DN and Password empty.')"
66-
:placeholder="t('user_ldap', 'Password')"
70+
:label="t('user_ldap', 'Password')"
6771
autocomplete="off" />
6872

6973
<NcButton :disabled="!needsToSaveCredentials" @click="updateCredentials">

0 commit comments

Comments
 (0)