-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Description
Tasks
- implement CI for 32bit
- changes that will need reverting:
- implement setup check to block installing on 32bit (master)
- make admin overview check more clear that 32bit compatibility is removed with nc26 (master and stable25)
- make docs more clear that 32bit compatibility is removed with nc26 (master and stable25)
- implement check into updater to block upgrades to nc26 on 32bit (master and stable25)
- implement 32bit tests for things formerly breaking on 32Bit (where not mitigate-able due to technical restrictions)
- test with each CI run would be fine plus running the whole suite (that would work on 32bit" regularly (i.e. daily or weekly against master/stable*) would be enough to not burn too much CI resources
Regarding the typing, instead of removing typing like for stable25 we should use the union types available thanks to PHP 8 and use int|float.
Running the CI on 32 bits is not that straightforward because Github does not propose it so one has to run a docker in a docker or something along these lines. Need someone with knowledge on CI/docker.
On Drone, 64bit hardware is likely able to run 32bit code.
See "arch" field in https://docs.drone.io/pipeline/configuration/
It should not be too hard to fix once we have proper CI, given we have the PR for stable25 to use as an example of how to fix stuff. That said it seems stable25 is still not passing test suite on 32bits.
Estimate: possibly 2 weeks effort if not more depending on hurdles and whether we need to port Github workflow tests to Drone