Merge 'origin/master' into stable-19.0 and bump to 19.0.0 RC2

because master doesn't contain any changes that should not be contained in 19.0.0, backport PRs will be dismissed and RC2 will have the state of current master

Author: mahibi

.devcontainer/Dockerfile

@@ -4,7 +4,7 @@ ARG DEBIAN_FRONTEND=noninteractive
 ENV ANDROID_HOME=/usr/lib/android-sdk
 
 RUN apt-get update -y
-RUN apt-get install -y unzip wget openjdk-11-jdk vim
+RUN apt-get install -y unzip wget openjdk-17-jdk vim
 
 RUN wget https://dl.google.com/android/repository/commandlinetools-linux-6858069_latest.zip -O /tmp/commandlinetools.zip
 RUN cd /tmp && unzip commandlinetools.zip

.devcontainer/README.md

@@ -4,6 +4,6 @@
 -->
 # Instructions
 
-1. Start a DevContainer either on GitHub Codespaces or locally in VSCode
-2. Accept all licenses by running `yes | /usr/lib/android-sdk/cmdline-tools/latest/bin/sdkmanager --licenses`
-3. You can now build the app using `./gradlew clean build`
+1. Start a DevContainer either on GitHub Codespaces or locally in VSCode.
+2. Accept all licenses by running `yes | /usr/lib/android-sdk/cmdline-tools/latest/bin/sdkmanager --licenses`.
+3. You can now build the app using `./gradlew clean build`.

.github/workflows/codeql.yml

@@ -39,7 +39,7 @@ jobs:
         with:
           swap-size-gb: 10
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@05963f47d870e2cb19a537396c1f668a348c7d8f # v3.24.8
+        uses: github/codeql-action/init@1b1aada464948af03b950897e5eb522f92603cc2 # v3.24.9
         with:
           languages: ${{ matrix.language }}
       - name: Set up JDK 17
@@ -53,4 +53,4 @@ jobs:
           echo "org.gradle.jvmargs=-Xmx4g -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError" > "$HOME/.gradle/gradle.properties"
           ./gradlew assembleDebug
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@05963f47d870e2cb19a537396c1f668a348c7d8f # v3.24.8
+        uses: github/codeql-action/analyze@1b1aada464948af03b950897e5eb522f92603cc2 # v3.24.9

.github/workflows/pr-feedback.yml

@@ -24,7 +24,7 @@ jobs:
         id: scrape
         with:
           website: 'https://nextcloud.com/team/'
-      - uses: marcelklehr/pr-feedback-action@601109aa729eb4c8d6d0ece7567b9d4901db4aef
+      - uses: marcelklehr/pr-feedback-action@1883b38a033fb16f576875e0cf45f98b857655c4
         with:
           feedback-message: |
             Hello there,

.github/workflows/reuse.yml

@@ -0,0 +1,17 @@
+# synced from @nextcloud/android-config
+
+# SPDX-FileCopyrightText: 2022 Free Software Foundation Europe e.V. <https://fsfe.org>
+#
+# SPDX-License-Identifier: CC0-1.0
+
+name: REUSE Compliance Check
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+    - name: REUSE Compliance Check
+      uses: fsfe/reuse-action@a46482ca367aef4454a87620aa37c2be4b2f8106 # v3.0.0

.github/workflows/scorecard.yml

@@ -42,6 +42,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@05963f47d870e2cb19a537396c1f668a348c7d8f # v3.24.8
+        uses: github/codeql-action/upload-sarif@1b1aada464948af03b950897e5eb522f92603cc2 # v3.24.9
         with:
           sarif_file: results.sarif

.github/workflows/unit-tests.yml

@@ -28,7 +28,7 @@ jobs:
                     distribution: "temurin"
                     java-version: 17
             -   name: Run unit tests with coverage
-                uses: gradle/gradle-build-action@29c0906b64b8fc82467890bfb7a0a7ef34bda89e # v3.1.0
+                uses: gradle/gradle-build-action@fe59895742b4f984530980e4f693943577526b61 # v3.2.0
                 with:
                     arguments: testGplayDebugUnit
             -   name: Upload test artifacts

.idea/copyright/Nextcloud_Talk___Android_Client.xml

@@ -3,10 +3,18 @@ Upstream-Name: Nextcloud Talk - Android Client
 Upstream-Contact: Nextcloud Android team <[email protected]>
 Source: https://github.com/nextcloud/talk-android
 
-Files: app/src/main/res/values-*/strings.xml */.gitignore .idea/* scripts/analysis/findbugs-results.txt scripts/analysis/lint-results.txt app/src/test/resources/robolectric.properties app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker fastlane/metadata/* app/src/main/res/mipmap-*dpi/ic_launcher.png app/schemas/com.nextcloud.talk.data.source.local.TalkDatabase/*.json
+Files: app/src/main/res/values-*/strings.xml */.gitignore .idea/* app/src/test/resources/robolectric.properties app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker fastlane/metadata/*  app/schemas/com.nextcloud.talk.data.source.local.TalkDatabase/*.json app/src/generic/fastlane/metadata/android/*/full_description.txt
 Copyright: 2017-2024 Nextcloud GmbH and Nextcloud contributors
 License: GPL-3.0-or-later
 
+Files: app/src/*/res/mipmap-*dpi/ic_launcher.png app/src/*/ic_launcher-web.png 
+Copyright: 2017-2024 Nextcloud GmbH. All rights reserved. Trademarks apply, see https://nextcloud.com/trademarks/
+License: GPL-3.0-or-later
+
 Files: app/src/main/res/raw/tr110_1_kap8_3_freiton1.ogg
 Copyright: 2007 arvedkrynil
 License: CC-BY-SA-3.0
+
+Files: app/src/main/res/raw/librem_by_feandesign_call.ogg app/src/main/res/raw/librem_by_feandesign_message.ogg
+Copyright: Feandesign
+License: CC0-1.0