Skip to content

Commit 53401af

Browse files
tobiasKaminskyAndyScherzinger
authored andcommitted
wip
Signed-off-by: tobiasKaminsky <[email protected]>
1 parent 2deb17b commit 53401af

File tree

6 files changed

+11
-14
lines changed

6 files changed

+11
-14
lines changed

app/build.gradle

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,6 @@ dependencies {
189189
implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
190190
androidTestImplementation "androidx.work:work-testing:${workVersion}"
191191
implementation 'com.google.android:flexbox:2.0.1'
192-
implementation ('com.gitlab.bitfireAT:dav4jvm:2.1.3', {
193-
exclude group: 'org.ogce', module: 'xpp3' // Android comes with its own XmlPullParser
194-
})
195192
implementation 'org.conscrypt:conscrypt-android:2.5.2'
196193

197194
implementation "androidx.camera:camera-core:${androidxCameraVersion}"
@@ -312,7 +309,7 @@ dependencies {
312309

313310
implementation 'com.github.nextcloud.android-common:ui:0.3.0'
314311

315-
implementation("com.github.nextcloud:android-library:$androidLibraryVersion") {
312+
api("com.github.nextcloud:android-library:$androidLibraryVersion") {
316313
exclude group: 'org.ogce', module: 'xpp3' // unused in Android and brings wrong Junit version
317314
}
318315
}

app/src/androidTest/java/com/nextcloud/talk/components/filebrowser/webdav/ReadFilesystemOperationIT.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ReadFilesystemOperationIT {
2323
this.username = username
2424
token = password
2525
}
26-
val sut = ReadFilesystemOperation(client, user, "", 1)
26+
val sut = ReadFilesystemOperation(client, user, "/", 1)
2727
val data = sut.readRemotePath().data as List<BrowserFile>
2828
assertEquals(1, data.size)
2929
}

app/src/main/java/com/nextcloud/talk/components/filebrowser/models/BrowserFile.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ data class BrowserFile(
9494
browserFile.modifiedTimestamp = property.lastModified
9595
}
9696
is GetContentType -> {
97-
browserFile.mimeType = property.type
97+
browserFile.mimeType = property.type?.toString()
9898
}
9999
is OCSize -> {
100100
browserFile.size = property.ocSize

app/src/main/java/com/nextcloud/talk/components/filebrowser/webdav/ReadFilesystemOperation.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@
3636
import java.util.ArrayList;
3737
import java.util.List;
3838

39+
import androidx.annotation.NonNull;
3940
import at.bitfire.dav4jvm.DavResource;
41+
import at.bitfire.dav4jvm.MultiResponseCallback;
4042
import at.bitfire.dav4jvm.Response;
4143
import at.bitfire.dav4jvm.exception.DavException;
42-
import kotlin.Unit;
43-
import kotlin.jvm.functions.Function2;
4444
import okhttp3.HttpUrl;
4545
import okhttp3.OkHttpClient;
4646

@@ -75,10 +75,11 @@ public DavResponse readRemotePath() {
7575
final Response[] rootElement = new Response[1];
7676

7777
try {
78-
new DavResource(okHttpClient, HttpUrl.parse(url)).propfind(depth, WebdavUtils.getAllPropertiesList(),
79-
new Function2<Response, Response.HrefRelation, Unit>() {
78+
new DavResource(okHttpClient, HttpUrl.parse(url)).propfind(depth,
79+
WebdavUtils.getAllPropertiesList(),
80+
new MultiResponseCallback() {
8081
@Override
81-
public Unit invoke(Response response, Response.HrefRelation hrefRelation) {
82+
public void onResponse(@NonNull Response response, @NonNull Response.HrefRelation hrefRelation) {
8283
davResponse.setResponse(response);
8384
switch (hrefRelation) {
8485
case MEMBER:
@@ -90,7 +91,6 @@ public Unit invoke(Response response, Response.HrefRelation hrefRelation) {
9091
case OTHER:
9192
default:
9293
}
93-
return Unit.INSTANCE;
9494
}
9595
});
9696
} catch (IOException | DavException e) {

app/src/main/java/com/nextcloud/talk/components/filebrowser/webdav/ReadFolderListingOperation.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ class ReadFolderListingOperation(okHttpClient: OkHttpClient, currentUser: User,
151151
remoteFileBrowserItem.modifiedTimestamp = property.lastModified
152152
}
153153
is GetContentType -> {
154-
remoteFileBrowserItem.mimeType = property.type
154+
remoteFileBrowserItem.mimeType = property.type?.toString()
155155
}
156156
is OCSize -> {
157157
remoteFileBrowserItem.size = property.ocSize

app/src/main/java/com/nextcloud/talk/upload/chunked/ChunkedFileUploader.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ class ChunkedFileUploader(
367367
remoteFileBrowserItem.modifiedTimestamp = property.lastModified
368368
}
369369
is GetContentType -> {
370-
remoteFileBrowserItem.mimeType = property.type
370+
remoteFileBrowserItem.mimeType = property.type?.toString()
371371
}
372372
is OCSize -> {
373373
remoteFileBrowserItem.size = property.ocSize

0 commit comments

Comments
 (0)