style(lint): replace magic number with constant

AndyScherzinger · AndyScherzinger · commit 9e3840c3a9ee · 2025-01-16T16:29:39.000+01:00
Signed-off-by: Andy Scherzinger &lt;info@andy-scherzinger.de&gt;
diff --git a/app/src/main/java/com/nextcloud/talk/adapters/messages/PreviewMessageViewHolder.kt b/app/src/main/java/com/nextcloud/talk/adapters/messages/PreviewMessageViewHolder.kt
@@ -150,7 +150,7 @@ abstract class PreviewMessageViewHolder(itemView: View?, payload: Any?) :
             messageText.text = ""
         }
         itemView.setTag(R.string.replyable_message_view_tag, message.replyable)
-        val paddingSide = DisplayUtils.convertDpToPixel(8.0f, context!!).toInt()
+        val paddingSide = DisplayUtils.convertDpToPixel(HORIZONTAL_REACTION_PADDING, context!!).toInt()
         Reaction().showReactions(
             message,
             ::clickOnReaction,
@@ -339,5 +339,6 @@ abstract class PreviewMessageViewHolder(itemView: View?, payload: Any?) :
         const val ACTOR_ID_CHANGELOG = "changelog"
         const val KEY_NAME = "name"
         const val MIN_IMAGE_HEIGHT = 100F
+        const val HORIZONTAL_REACTION_PADDING = 8.0F
     }
 }
diff --git a/detekt.yml b/detekt.yml
@@ -1,7 +1,7 @@
 # SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
 # SPDX-License-Identifier: GPL-3.0-or-later
 build:
-  maxIssues: 82
+  maxIssues: 78
   weights:
     # complexity: 2
     # LongParameterList: 1

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ abstract class PreviewMessageViewHolder(itemView: View?, payload: Any?) :`
`150`	`150`	`messageText.text = ""`
`151`	`151`	`}`
`152`	`152`	`itemView.setTag(R.string.replyable_message_view_tag, message.replyable)`
`153`		`- val paddingSide = DisplayUtils.convertDpToPixel(8.0f, context!!).toInt()`
	`153`	`+ val paddingSide = DisplayUtils.convertDpToPixel(HORIZONTAL_REACTION_PADDING, context!!).toInt()`
`154`	`154`	`Reaction().showReactions(`
`155`	`155`	`message,`
`156`	`156`	`::clickOnReaction,`
`@@ -339,5 +339,6 @@ abstract class PreviewMessageViewHolder(itemView: View?, payload: Any?) :`
`339`	`339`	`const val ACTOR_ID_CHANGELOG = "changelog"`
`340`	`340`	`const val KEY_NAME = "name"`
`341`	`341`	`const val MIN_IMAGE_HEIGHT = 100F`
	`342`	`+ const val HORIZONTAL_REACTION_PADDING = 8.0F`
`342`	`343`	`}`
`343`	`344`	`}`