Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up fixes for 'Archive Conversations #4624

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Follow up fixes for 'Archive Conversations #4624

wants to merge 2 commits into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 16, 2025 •
edited
Loading

🚧 TODO

  • It should be possible to archive from the context menu on the conversation list
  • The option somehow does not look like a option, maybe because other things around it are red and participant list?
  • The option can not be toggled multiple times: After turning it on, you need to leave the details in order to be able to turn if off again. Pressing it a second time without leaving and coming back does not do anything.
  • After filtering for archived conversations and forgetting about it, i was shocked for some seconds why the conversations don't load. Turned out i had the filter enabled but no conv is archived. In this case we should give a hint about it as a text in middle of the screen.
  • the "Unread mentions" bubble is not updated when filtering

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004
First commit - Made options yellow
6104116 
Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004
More fixes
bbb2dc2 
- Now possible to archive/unarchive conversations from dialog
- Now possible to archive and unarchive conversations in settings without leaving the screen
- Better UX

Signed-off-by: rapterjet2004 <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4624-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@rapterjet2004 rapterjet2004 marked this pull request as ready for review January 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archive conversation follow ups #2 Archive conversation option follow ups
1 participant
@rapterjet2004