Sound setting not saved across restarts

[fraenki]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. go to Talk settings -> Sounds
2. disable "Play sounds when participants join or leave a call"
3. a message "sounds setting saved" appears
4. quit Talk Desktop
5. on next start of Talk Desktop, the setting is enabled again

Expected behaviour

The option "Play sounds when participants join or leave a call" should remain disabled.

Actual behaviour

The option "Play sounds when participants join or leave a call" is enabled after a restart of Talk Desktop.

Diagnosis and logs

none

[fraenki]

Verified: bug reproducible on release 1.1.5.

[Antreesy]

When toggling, setting is updated on API:

https://github.com/nextcloud/spreed/blob/1602b314591e567582485d10d7327652b5016e3f/src/services/settingsService.ts#L71-L80

Desktop client has no access to initial state and always defaults to play them:

talk-desktop/src/shared/setupWebPage.js

Line 148 in b11e974

play_sounds: true, // Consider playing sound enabled by default on desktop until we have settings

Hotfix would be to update it upstream (to always save it to BrowserStorage as well, and rely on storage value during initialization.
(but then update via web won't change it in client)
Or we provide it via capabilities.spreed.config