Commit 1ade042
committed
fix(sync): actually disable browser broadcast
It was still enabled as we mistyped the `disableBc` option.
We cannot use it right now as the y-websocket room name
does not include the base version etag.
Therefore different tabs may be in different sessions
and would risk syncing never the less.
Observed this when reloading the editor on an outdated session:
* Cleaning up the old yjs document took a while in the beforeDestroy callback.
* The new document was already created.
* The new y-websocket provider issued a sync step 1 via browser broadcast.
* The old y-websocket provider responded and send its full state.
Signed-off-by: Max <[email protected]>1 parent 34dbc9a commit 1ade042
File tree
3 files changed
+2
-3
lines changed- src
- components
- composables
- services
3 files changed
+2
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
484 | 484 | | |
485 | 485 | | |
486 | 486 | | |
487 | | - | |
| 487 | + | |
488 | 488 | | |
489 | 489 | | |
490 | 490 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
| |||
0 commit comments