refactor(WebSocketPolyfill): cleanup redundant open handling

Remove return value from `syncService.open`
and redundant handler in `WebSocketPolyfill`.

`syncService.open` triggers `opened` and `loaded` events
which both set the `version` and `session`.

Signed-off-by: Max <[email protected]>

Author: max-nextcloud

src/services/SyncService.js

@@ -106,7 +106,7 @@ class SyncService {
 
 	async open({ fileId, initialSession }) {
 		if (this.hasActiveConnection) {
-			return this.connectionState
+			return
 		}
 		const connect = initialSession
 			? Promise.resolve(new Connection({ data: initialSession }, {}))
@@ -115,15 +115,13 @@ class SyncService {
 		this.#connection = await connect
 		if (!this.#connection) {
 			// Error was already emitted in connect
-			return null
+			return
 		}
 		this.backend = new PollingBackend(this, this.#connection)
 		this.version = this.#connection.docStateVersion
 		this.baseVersionEtag = this.#connection.document.baseVersionEtag
 		this.emit('opened', this.connectionState)
 		this.emit('loaded', this.connectionState)
-
-		return this.connectionState
 	}
 
 	startSync() {

src/services/WebSocketPolyfill.js

@@ -40,11 +40,6 @@ export default function initWebSocketPolyfill(syncService, fileId, initialSessio
 					this.#version = version
 					this.#session = session
 				},
-				loaded: ({ version, session, content }) => {
-					logger.debug('loaded ', { version, session })
-					this.#version = version
-					this.#session = session
-				},
 				sync: ({ steps, version }) => {
 					logger.debug('synced ', { version, steps })
 					this.#version = version
@@ -57,15 +52,7 @@ export default function initWebSocketPolyfill(syncService, fileId, initialSessio
 				},
 			})
 
-			syncService.open({ fileId, initialSession }).then((data) => {
-				if (syncService.hasActiveConnection) {
-					const { version, session } = data
-					this.#version = version
-					this.#session = session
-
-					this.onopen?.()
-				}
-			})
+			syncService.open({ fileId, initialSession }).then(() => this.onopen?.())
 		}
 
 		#registerHandlers(handlers) {