Merge pull request #7940 from nextcloud/chore/convert-cy-to-play

Convert print test from cypress to playwright

Author: max-nextcloud

.eslintrc.cjs

@@ -13,6 +13,14 @@ module.exports = {
 				'vue/first-attribute-linebreak': 'off',
 			},
 		},
+		{
+			files: ['**/*.ts'],
+			rules: {
+				// Do not err out on constructors with parameter properties only.
+				'no-useless-constructor': 'off',
+				'@typescript-eslint/no-useless-constructor': 'error',
+			},
+		},
 	],
 	rules: {
 		'import/no-unresolved': [1, { ignore: ['\\.svg\\?raw$'] }],

.gitignore

@@ -18,3 +18,7 @@ webpack-stats.json
 
 # js folder, to be updated wth --force
 /js
+
+# Playwright snapshots - only keep the ci version in git
+playwright/e2e/*-snapshots/**
+!playwright/e2e/*-snapshots/*-on-ci-**

REUSE.toml

@@ -30,7 +30,7 @@ SPDX-FileCopyrightText = "Nils Adermann, Jordi Boggiano"
 SPDX-License-Identifier = "MIT"
 
 [[annotations]]
-path = ["cypress/fixtures/**", "cypress/snapshots/**", "src/tests/fixtures/**", "src/tests/**/__snapshots__/**"]
+path = ["cypress/fixtures/**", "cypress/snapshots/**", "playwright/support/fixtures/files/**", "playwright/e2e/*-snapshots/**", "src/tests/fixtures/**", "src/tests/**/__snapshots__/**"]
 precedence = "aggregate"
 SPDX-FileCopyrightText = "2019-2025 Nextcloud GmbH and Nextcloud contributors"
 SPDX-License-Identifier = "AGPL-3.0-or-later"

cypress/e2e/print.spec.js

@@ -5,21 +5,24 @@
 
 import { expect, mergeTests } from '@playwright/test'
 import { test as editorTest } from '../support/fixtures/editor'
-import { test as randomUserTest } from '../support/fixtures/random-user'
 import { test as uploadFileTest } from '../support/fixtures/upload-file'
 
-const test = mergeTests(editorTest, randomUserTest, uploadFileTest)
+const test = mergeTests(editorTest, uploadFileTest)
 
-test.beforeEach(async ({ file }) => {
-	await file.open()
+test.beforeEach(async ({ open }) => {
+	await open()
 })
 
 test.describe('Changing mimetype from markdown to plaintext', () => {
-	test('resets the document session and indexed db', async ({ editor, file }) => {
+	test('resets the document session and indexed db', async ({
+		close,
+		editor,
+		file,
+	}) => {
 		await editor.typeHeading('Hello world')
-		await file.close()
-		await file.move('test.txt')
-		await file.open()
+		await close()
+		const plaintext = await file.move('test.txt')
+		await plaintext.open()
 		await expect(editor.content).toHaveText('## Hello world')
 		await expect(editor.getHeading()).not.toBeVisible()
 	})
@@ -28,12 +31,16 @@ test.describe('Changing mimetype from markdown to plaintext', () => {
 test.describe('Changing mimetype from plain to markdown', () => {
 	test.use({ fileName: 'empty.txt' })
 
-	test('resets the document session and indexed db', async ({ editor, file }) => {
+	test('resets the document session and indexed db', async ({
+		close,
+		editor,
+		file,
+	}) => {
 		await editor.type('## Hello world')
 		await expect(editor.content).toHaveText('## Hello world')
-		await file.close()
-		await file.move('test.md')
-		await file.open()
+		await close()
+		const markdown = await file.move('test.md')
+		await markdown.open()
 		await expect(editor.getHeading({ name: 'Hello world' })).toBeVisible()
 	})
 })

cypress/snapshots/base/cypress/e2e/print.spec.js/print view in single-file share.png

@@ -5,17 +5,16 @@
 
 import { devices, expect, mergeTests } from '@playwright/test'
 import { test as editorTest } from '../support/fixtures/editor'
-import { test as randomUserTest } from '../support/fixtures/random-user'
 import { test as uploadFileTest } from '../support/fixtures/upload-file'
 
-const test = mergeTests(editorTest, randomUserTest, uploadFileTest)
+const test = mergeTests(editorTest, uploadFileTest)
 
 test.use({
 	...devices['Moto G4'],
 })
 
-test.beforeEach(async ({ file }) => {
-	await file.open()
+test.beforeEach(async ({ open }) => {
+	await open()
 })
 
 test('Formatting help', async ({ editor }) => {

cypress/snapshots/base/cypress/e2e/print.spec.js/print view in viewer.png

@@ -6,17 +6,16 @@
 import { expect, mergeTests } from '@playwright/test'
 import { test as editorTest } from '../support/fixtures/editor'
 import { test as offlineTest } from '../support/fixtures/offline'
-import { test as randomUserTest } from '../support/fixtures/random-user'
 import { test as uploadFileTest } from '../support/fixtures/upload-file'
 
-const test = mergeTests(editorTest, offlineTest, randomUserTest, uploadFileTest)
+const test = mergeTests(editorTest, offlineTest, uploadFileTest)
 
 // As we switch on and off the network
 // we cannot run tests in parallel.
 test.describe.configure({ mode: 'serial' })
 
-test.beforeEach(async ({ file }) => {
-	await file.open()
+test.beforeEach(async ({ open }) => {
+	await open()
 })
 
 test('Offline state indicator', async ({ editor, setOffline }) => {
@@ -48,7 +47,7 @@ test('typing offline and coming back online', async ({
 	setOffline,
 	setOnline,
 }) => {
-	await expect(editor.locator).toBeVisible()
+	await expect(editor.el).toBeVisible()
 	await setOffline()
 	await editor.typeHeading('Hello world')
 	await setOnline()

playwright/e2e/change-mime-type.spec.ts

@@ -0,0 +1,27 @@
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import { expect, mergeTests } from '@playwright/test'
+import { hostname } from 'os'
+import { test as editorTest } from '../support/fixtures/editor'
+import { loadFixture } from '../support/fixtures/loadFixture'
+import { test as sharedFileTest } from '../support/fixtures/shared-file'
+import { test as uploadFileTest } from '../support/fixtures/upload-file'
+
+const fileTest = mergeTests(editorTest, uploadFileTest)
+const shareTest = mergeTests(editorTest, sharedFileTest)
+const host = process.env.CI ? 'ci' : hostname()
+
+new Map([
+	[`Own file on ${host}`, fileTest],
+	[`Shared file on ${host}`, shareTest],
+]).forEach((test, name) => {
+	test.use({ fileContent: loadFixture('print.md') })
+	test(name, async ({ open, page }) => {
+		await open()
+		await page.emulateMedia({ media: 'print' })
+		await expect(page).toHaveScreenshot({ fullPage: true })
+	})
+})