fix(SaveService): Don't autosave if yjs reports pendingStructs

Yjs pendingStructs most likely mean that the local yjs document state
is missing a step. So let's not autosave such an inconstent state to the
server.

Signed-off-by: Jonas <[email protected]>

Author: mejo-

src/composables/useSaveService.ts

@@ -23,6 +23,7 @@ export const provideSaveService = (
 		syncService,
 		serialize,
 		getDocumentState: () => getDocumentState(ydoc),
+		hasYjsPendingStructs: () => !!ydoc.store.pendingStructs,
 	})
 	provide(saveServiceKey, saveService)
 	return { saveService }

src/services/SaveService.ts

@@ -23,23 +23,27 @@ class SaveService {
 	syncService
 	serialize
 	getDocumentState
+	hasYjsPendingStructs
 	autosave
 
 	constructor({
 		connection,
 		syncService,
 		serialize,
 		getDocumentState,
+		hasYjsPendingStructs,
 	}: {
 		connection: ShallowRef<Connection | undefined>
 		syncService: SyncService
 		serialize: () => string
 		getDocumentState: () => string
+		hasYjsPendingStructs: () => boolean
 	}) {
 		this.connection = connection
 		this.syncService = syncService
 		this.serialize = serialize
 		this.getDocumentState = getDocumentState
+		this.hasYjsPendingStructs = hasYjsPendingStructs
 		this.autosave = debounce(this._autosave.bind(this), AUTOSAVE_INTERVAL)
 		this.syncService.on('close', () => {
 			this.autosave.clear()
@@ -98,6 +102,10 @@ class SaveService {
 	}
 
 	_autosave() {
+		// Don't autosave if we have pendingStructs (i.e. document state misses a step)
+		if (this.hasYjsPendingStructs()) {
+			return
+		}
 		return this.save({ manualSave: false }).catch((error) => {
 			logger.error('Failed to autosave document.', { error })
 		})