Populate avatar from SAML attribute #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is my first code contribution to a Nextcloud project, so I am not sure, how the merging process works. Do I need to do something for this PR being merged? |
blizzz
requested changes
May 17, 2021
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
…_mapping config setting and disabling image upload if avatar_mapping configuration is set Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
…their avatar Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 7.0.1 to 7.3.0. - [Release notes](https://github.com/guzzle/guzzle/releases) - [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md) - [Commits](guzzle/guzzle@7.0.1...7.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Some SAML servers require this type of decoding, otherwise the SLO request fails. Ideally the library would perform both verifications (SAML-Toolkits/php-saml#466), but it seems upstream doesn't want to perform this change. Until we have considered a better solution for this, this adds a new checkbox that one can configure. Ref #403 Signed-off-by: Lukas Reschke <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Lukas Reschke <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Lukas Reschke <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]> Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
Signed-off-by: Philipp Seßner <[email protected]>
…ansifex Signed-off-by: Philipp Seßner <[email protected]>
Lumrenion
commented
Aug 26, 2021
|
Love this function, when will it be commit? |
|
I missed the notification in August. Will revisit after #558 is merged and shipped. |
Cool, thanks for your working. |
|
/rebase |
|
@Lumrenion could you rebase, please? |
|
I rebased the PR and did the necessary changes for this to work with the new SAMLSettings |
|
Not sure the rebase worked with the 40 commits added here |
|
True, it has commits on my fork that definitely came from this master. Should I create a new fork and manually do the changes again? |
either retry to rebase, or do a new PR. You can apply your commits, not need to redo everything by hand. |
|
Created a new PR with the actual changes only: #640 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #187.