update updatenotification to be able to run the cronjob every day (#1141)

Co-authored-by: Daniel Hansson <[email protected]>

Author: szaimen

nextcloud_install_production.sh

@@ -396,7 +396,7 @@ occ_command config:system:set upgrade.disable-web --value="true"
 print_text_in_color "$ICyan" "Configuring update notifications specific for this server..."
 download_static_script updatenotification
 check_command chmod +x "$SCRIPTS"/updatenotification.sh
-crontab -u root -l | { cat; echo "59 $AUT_UPDATES_TIME * * 6 $SCRIPTS/updatenotification.sh > /dev/null 2>&1"; } | crontab -u root -
+crontab -u root -l | { cat; echo "59 $AUT_UPDATES_TIME * * * $SCRIPTS/updatenotification.sh > /dev/null 2>&1"; } | crontab -u root -
 
 # Change values in php.ini (increase max file size)
 # max_execution_time

static/updatenotification.sh

@@ -19,18 +19,32 @@ debug_mode
 # Check if root
 root_check
 
+REPORTEDNCVERSION=""
+
+if [ "$CURRENTVERSION" == "$NCVERSION" ]
+then
+    print_text_in_color "$IGreen" "You already run the latest version! ($NCVERSION)"
+    exit
+fi
+
+if [ "$REPORTEDNCVERSION" == "$NCVERSION" ]
+then
+    print_text_in_color "$ICyan" "The notification regarding the new Nextcloud update has been already reported! ($NCVERSION)"
+    exit
+fi
+
 if version_gt "$NCVERSION" "$CURRENTVERSION"
 then
     if crontab -l -u root | grep $SCRIPTS/update.sh
     then
         notify_admin_gui \
         "New Nextcloud version!" \
         "Nextcloud $NCVERSION just became available. Since you are running Automatic Updates at $AUT_UPDATES_TIME:00, you don't need to bother about updating the server manually, as that's already taken care of."
+        sed -i "s|^REPORTEDNCVERSION.*|REPORTEDNCVERSION=$NCVERSION|" $SCRIPTS/updatenotification.sh
     else
         notify_admin_gui \
-       "Update availabile!" \
+        "Update available!" \
         "Nextcloud $NCVERSION is available. Please run 'sudo bash /var/scripts/update.sh' from your CLI to update your server."
+        sed -i "s|^REPORTEDNCVERSION.*|REPORTEDNCVERSION=$NCVERSION|" $SCRIPTS/updatenotification.sh
     fi
-else
-    print_text_in_color "$IGreen" "You already run the latest version! ($NCVERSION)"
 fi