From 80e7d0542605604d9faa4fc756a59bf159728fe4 Mon Sep 17 00:00:00 2001 From: Daniel Hansson Date: Sat, 14 Dec 2024 19:58:08 +0100 Subject: [PATCH 1/6] add dnodesize For ZFS Signed-off-by: Daniel Hansson --- disk/format-sdb.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/disk/format-sdb.sh b/disk/format-sdb.sh index 1169ff5827..b24d369077 100644 --- a/disk/format-sdb.sh +++ b/disk/format-sdb.sh @@ -166,6 +166,7 @@ then check_command zfs set atime=off "$POOLNAME" check_command zfs set recordsize=128k "$POOLNAME" check_command zfs set logbias=latency "$POOLNAME" + check_command zfs set dnodesize=auto "$POOLNAME" else msg_box "It seems like /dev/$DEVTYPE does not exist. From f0772740e1c25f7ad5b435a521d2cd97c877079a Mon Sep 17 00:00:00 2001 From: Daniel Hansson Date: Sat, 14 Dec 2024 19:58:43 +0100 Subject: [PATCH 2/6] add option Signed-off-by: Daniel Hansson --- disk/format-chosen.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/disk/format-chosen.sh b/disk/format-chosen.sh index 52b88edc93..3444d41541 100644 --- a/disk/format-chosen.sh +++ b/disk/format-chosen.sh @@ -183,6 +183,7 @@ then check_command zfs set atime=off "$POOLNAME" check_command zfs set recordsize=128k "$POOLNAME" check_command zfs set logbias=latency "$POOLNAME" + check_command zfs set dnodesize=auto "$POOLNAME" else msg_box "It seems like /dev/$DEVTYPE does not exist. From d6501675b3a1f9484f19c82c970404e366702115 Mon Sep 17 00:00:00 2001 From: Daniel Hansson Date: Sun, 15 Dec 2024 01:35:16 +0100 Subject: [PATCH 3/6] SC Signed-off-by: Daniel Hansson --- disk/format-chosen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disk/format-chosen.sh b/disk/format-chosen.sh index 3444d41541..e5ee341fda 100644 --- a/disk/format-chosen.sh +++ b/disk/format-chosen.sh @@ -103,7 +103,7 @@ while done [[ -z "${devtype_present+x}" ]] do - printf "${BRed}$DEVTYPE is not a valid disk. Please try again.${Color_Off}\n" + print_text_in_color "BRed" "$DEVTYPE is not a valid disk. Please try again." : done From 7c52571babb2a3e0eb4be5e578c46d36f0a6f33b Mon Sep 17 00:00:00 2001 From: Daniel Hansson Date: Sun, 15 Dec 2024 01:40:52 +0100 Subject: [PATCH 4/6] fix typo Signed-off-by: Daniel Hansson --- disk/format-chosen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disk/format-chosen.sh b/disk/format-chosen.sh index e5ee341fda..f92841fb27 100644 --- a/disk/format-chosen.sh +++ b/disk/format-chosen.sh @@ -103,7 +103,7 @@ while done [[ -z "${devtype_present+x}" ]] do - print_text_in_color "BRed" "$DEVTYPE is not a valid disk. Please try again." + print_text_in_color "$BRed" "$DEVTYPE is not a valid disk. Please try again." : done From ccdd35543385d75ab5c5da6cab6d6ed4ceb10ecb Mon Sep 17 00:00:00 2001 From: Daniel Hansson Date: Sun, 15 Dec 2024 01:44:23 +0100 Subject: [PATCH 5/6] only on efi Signed-off-by: Daniel Hansson --- disk/format-chosen.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/disk/format-chosen.sh b/disk/format-chosen.sh index f92841fb27..212a192c89 100644 --- a/disk/format-chosen.sh +++ b/disk/format-chosen.sh @@ -183,7 +183,11 @@ then check_command zfs set atime=off "$POOLNAME" check_command zfs set recordsize=128k "$POOLNAME" check_command zfs set logbias=latency "$POOLNAME" - check_command zfs set dnodesize=auto "$POOLNAME" + if [ -d /sys/firmware/efi ] + then + # dnodesize can't boot on BIOS, only UEFI mode + check_command zfs set dnodesize=auto "$POOLNAME" + fi else msg_box "It seems like /dev/$DEVTYPE does not exist. From 33322f0fe5195cd005615303e3889c08470eb6b8 Mon Sep 17 00:00:00 2001 From: Daniel Hansson Date: Sun, 15 Dec 2024 01:45:00 +0100 Subject: [PATCH 6/6] same change Signed-off-by: Daniel Hansson --- disk/format-sdb.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/disk/format-sdb.sh b/disk/format-sdb.sh index b24d369077..81475c4d48 100644 --- a/disk/format-sdb.sh +++ b/disk/format-sdb.sh @@ -166,7 +166,11 @@ then check_command zfs set atime=off "$POOLNAME" check_command zfs set recordsize=128k "$POOLNAME" check_command zfs set logbias=latency "$POOLNAME" - check_command zfs set dnodesize=auto "$POOLNAME" + if [ -d /sys/firmware/efi ] + then + # dnodesize can't boot on BIOS, only UEFI mode + check_command zfs set dnodesize=auto "$POOLNAME" + fi else msg_box "It seems like /dev/$DEVTYPE does not exist.