chore: support Nextcloud 34

Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>

Author: hweihwang

appinfo/info.xml

@@ -40,7 +40,7 @@ The official whiteboard app for Nextcloud. It allows users to create and share w
 	<screenshot>https://raw.githubusercontent.com/nextcloud/whiteboard/main/screenshots/screenshot1.png</screenshot>
 
 	<dependencies>
-		<nextcloud min-version="28" max-version="33"/>
+		<nextcloud min-version="28" max-version="34"/>
 	</dependencies>
 
 	<settings>

lib/Controller/RecordingController.php

@@ -163,7 +163,8 @@ private function initializeRecordingState(int $fileId, string $jwt): void {
 
 	private function createRecordingResponse(): PublicTemplateResponse {
 		$csp = new ContentSecurityPolicy();
-		$csp->allowEvalScript();
+		// NC34 removed allowEvalScript(), but the recording bundle still needs unsafe-eval.
+		$csp->addAllowedScriptDomain('\'unsafe-eval\'');
 
 		$response = new PublicTemplateResponse($this->appName, 'recording');
 		$response->setFooterVisible();

lib/Service/File/GetFileFromPublicSharingTokenService.php

@@ -12,6 +12,7 @@
 use InvalidArgumentException;
 use OCP\Constants;
 use OCP\Files\File;
+use OCP\Files\Folder;
 use OCP\Files\NotFoundException;
 use OCP\Share\Exceptions\ShareNotFound;
 use OCP\Share\IManager as ShareManager;
@@ -51,6 +52,10 @@ public function getFile(): File {
 			return $node;
 		}
 
+		if (!$node instanceof Folder) {
+			throw new InvalidArgumentException('No proper share data');
+		}
+
 		$node = $node->getFirstNodeById($this->fileId);
 
 		if ($node instanceof File) {

lib/Settings/Admin.php

@@ -32,7 +32,7 @@ public function getForm(): TemplateResponse {
 			'whiteboard',
 			'admin',
 			[],
-			'blank'
+			TemplateResponse::RENDER_AS_BLANK
 		);
 		$csp = new ContentSecurityPolicy();
 		$csp->addAllowedConnectDomain('*');

lib/Settings/Personal.php

@@ -37,7 +37,7 @@ public function getForm(): TemplateResponse {
 			'whiteboard',
 			'personal',
 			[],
-			'blank'
+			TemplateResponse::RENDER_AS_BLANK
 		);
 		$csp = new ContentSecurityPolicy();
 		$csp->addAllowedConnectDomain('*');

playwright/e2e/version-preview.spec.ts

@@ -24,6 +24,13 @@ const versionPropfindBody = `<?xml version="1.0"?>
 	</d:prop>
 </d:propfind>`
 
+const skipWhenVersionContentUnavailable = () => {
+	test.skip(
+		process.env.SERVER_VERSION === 'stable29',
+		'Nextcloud 29 does not expose version content over the versions DAV endpoint',
+	)
+}
+
 const extractVersionIds = (xml: string, userId: string, fileId: number | string): string[] => {
 	const prefix = `/remote.php/dav/versions/${userId}/versions/${fileId}/`
 	const hrefRegex = /<[^:>]*:href>([^<]+)<\/[^:>]*:href>/g
@@ -189,6 +196,7 @@ test('version preview banner shows and exits to live board', async ({
 	page,
 	user,
 }) => {
+	skipWhenVersionContentUnavailable()
 	test.setTimeout(120000)
 	const boardName = `Version preview ${Date.now()}`
 	const initialText = 'Version one'
@@ -223,6 +231,7 @@ test('restore version replaces current content', async ({
 	page,
 	user,
 }) => {
+	skipWhenVersionContentUnavailable()
 	test.setTimeout(120000)
 	const boardName = `Version restore ${Date.now()}`
 	const initialText = 'Restore one'