Skip to content

Commit a3b4960

Browse files
authored
Merge pull request #1140 from nextgenusfs/bugfix_1139_pkgversion
remove use of pkg_version which is deprecated, bug #1139
2 parents a2524ae + 1a84612 commit a3b4960

File tree

5 files changed

+19
-15
lines changed

5 files changed

+19
-15
lines changed

funannotate/annotate.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import funannotate.library as lib
66
from funannotate.aux_scripts.fasta2agp import parse_scaffolds_makeagp
7-
from pkg_resources import parse_version
87
import sys
98
import os
109
import subprocess
@@ -1039,16 +1038,16 @@ def __init__(self, prog):
10391038
"--cpu",
10401039
str(args.cpus),
10411040
]
1042-
if parse_version(get_emapper_version()) >= parse_version("2.1.0"):
1041+
if packaging.version.parse(get_emapper_version()) >= packaging.version.parse("2.1.0"):
10431042
if not os.path.isdir(args.tmpdir):
10441043
os.makedirs(args.tmpdir)
10451044
if not os.path.isdir(scratch_dir):
10461045
os.makedirs(scratch_dir)
10471046
cmd += ["--scratch_dir", scratch_dir, "--temp_dir", args.tmpdir]
10481047
if lib.MemoryCheck() >= 48:
10491048
cmd.append("--dbmem")
1050-
if parse_version(get_emapper_version()) >= parse_version("2.1.4"):
1051-
if parse_version(lib.getDiamondVersion()) < parse_version("2.0.11"):
1049+
if packaging.version.parse(get_emapper_version()) >= packaging.version.parse("2.1.4"):
1050+
if packaging.version.parse(lib.getDiamondVersion()) < packaging.version.parse("2.0.11"):
10521051
cmd += ["--dmnd_iterate", "no"]
10531052
lib.runSubprocess(cmd, os.path.join(outputdir, "annotate_misc"), lib.log)
10541053
if os.path.isdir(scratch_dir):

funannotate/check.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import sys
55
import os
66
import re
7-
import pkg_resources
7+
import importlib.metadata
88
import subprocess
99
import errno
1010
import shutil
@@ -35,10 +35,11 @@ def checkPerlModule(mod):
3535

3636
def checkPyModule(mod):
3737
try:
38-
vers = pkg_resources.get_distribution(mod).version
39-
except pkg_resources.DistributionNotFound:
40-
vers = False
41-
return vers
38+
version = importlib.metadata.version(mod)
39+
except importlib.metadata.PackageNotFoundError:
40+
# Handle the case where the package metadata is not found
41+
version = False
42+
return version
4243

4344

4445
def mycmp(version1, version2):

funannotate/funannotate.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,15 @@
88
import importlib
99
import subprocess
1010
import funannotate
11-
from pkg_resources import get_distribution
11+
import importlib.metadata
1212

1313
global package_name
1414
global __version__
1515
package_name = 'funannotate'
16-
__version__ = get_distribution(package_name).version
16+
try:
17+
__version__ = importlib.metadata.version(package_name)
18+
except importlib.metadata.PackageNotFoundError:
19+
__version__ = "Unknown"
1720

1821
default_help = """
1922
Usage: {:} <command> <arguments>

funannotate/library.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,9 +1092,11 @@ def getGeneBasename(fastafile):
10921092

10931093

10941094
def get_version():
1095-
from pkg_resources import get_distribution
1096-
1097-
__version__ = get_distribution("funannotate").version
1095+
import importlib.metadata
1096+
try:
1097+
__version__ = importlib.metadata.version("funannotate")
1098+
except importlib.metadata.PackageNotFoundError:
1099+
__version__ = False
10981100
return __version__
10991101

11001102

funannotate/train.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
from collections import defaultdict
1414
from Bio.SeqIO.FastaIO import SimpleFastaParser
1515
from Bio.SeqIO.QualityIO import FastqGeneralIterator
16-
# from pkg_resources import parse_version
1716

1817

1918
def runTrimmomaticPE(left, right, cpus=1):

0 commit comments

Comments
 (0)