fix: ensure Dialog modals render above popovers and edit overlays #15056
Annotations
9 errors and 1 notice
|
Run UI P0 domain
Process completed with exit code 1.
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L1044
2) [chromium] βΊ ui/settings-api-protocol.test.ts:1005:1 βΊ [P0] @critical Settings keeps Local CLI and BYOK model choices isolated after reopening
Retry #1 βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('settings-agent-model-popover-codex').getByRole('option', { name: /GPT 5\.5/i })
- locator resolved to <button type="button" role="option" aria-selected="false" aria-disabled="false" class="model-select-searchable__option" aria-labelledby="model-picker-gm1ky92w-option-1-label">β¦</button>
- attempting click action
2 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <details class="agent-cli-env settings-memory-advanced">β¦</details> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 20ms
2 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <details class="agent-cli-env settings-memory-advanced">β¦</details> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 100ms
62 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <details class="agent-cli-env settings-memory-advanced">β¦</details> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
1042 | await dialog.getByTestId('settings-agent-select-codex').click();
1043 | await dialog.getByRole('combobox', { name: 'Model', exact: true }).click();
> 1044 | await page.getByTestId('settings-agent-model-popover-codex').getByRole('option', { name: /GPT 5\.5/i }).click();
| ^
1045 | await expect.poll(async () => readSavedConfig(page)).toMatchObject({
1046 | mode: 'daemon',
1047 | agentId: 'codex',
at /home/runner/_work/open-design/open-design/e2e/ui/settings-api-protocol.test.ts:1044:107
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L0
2) [chromium] βΊ ui/settings-api-protocol.test.ts:1005:1 βΊ [P0] @critical Settings keeps Local CLI and BYOK model choices isolated after reopening
Retry #1 βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
Test timeout of 60000ms exceeded.
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L1044
2) [chromium] βΊ ui/settings-api-protocol.test.ts:1005:1 βΊ [P0] @critical Settings keeps Local CLI and BYOK model choices isolated after reopening
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('settings-agent-model-popover-codex').getByRole('option', { name: /GPT 5\.5/i })
- locator resolved to <button type="button" role="option" aria-selected="false" aria-disabled="false" class="model-select-searchable__option" aria-labelledby="model-picker-zgfvwte8-option-1-label">β¦</button>
- attempting click action
2 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <details class="agent-cli-env settings-memory-advanced">β¦</details> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 20ms
2 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <details class="agent-cli-env settings-memory-advanced">β¦</details> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 100ms
103 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <details class="agent-cli-env settings-memory-advanced">β¦</details> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
1042 | await dialog.getByTestId('settings-agent-select-codex').click();
1043 | await dialog.getByRole('combobox', { name: 'Model', exact: true }).click();
> 1044 | await page.getByTestId('settings-agent-model-popover-codex').getByRole('option', { name: /GPT 5\.5/i }).click();
| ^
1045 | await expect.poll(async () => readSavedConfig(page)).toMatchObject({
1046 | mode: 'daemon',
1047 | agentId: 'codex',
at /home/runner/_work/open-design/open-design/e2e/ui/settings-api-protocol.test.ts:1044:107
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L0
2) [chromium] βΊ ui/settings-api-protocol.test.ts:1005:1 βΊ [P0] @critical Settings keeps Local CLI and BYOK model choices isolated after reopening
Test timeout of 60000ms exceeded.
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L106
1) [chromium] βΊ ui/settings-api-protocol.test.ts:220:1 βΊ [P0] @critical BYOK quick fill provider updates fields and saved settings persist after closing and reopening
Retry #1 βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
Error: locator.click: Test timeout of 120000ms exceeded.
Call log:
- waiting for locator('[data-testid="settings-byok-provider-preset-popover"]').last().getByRole('option', { name: /DeepSeek β OpenAI/i })
- locator resolved to <button type="button" role="option" aria-selected="false" aria-disabled="false" class="model-select-searchable__option" aria-labelledby="model-picker-q4990rv6-option-7-label">β¦</button>
- attempting click action
2 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <p class="hint">Cap on the response length. Each model has a tuneβ¦</p> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <input type="url" inputmode="url" aria-label="Base URL" value="https://api.openai.com/v1"/> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
2 Γ retrying click action
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <span class="field-label-row">β¦</span> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
42 Γ retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <p class="hint">Cap on the response length. Each model has a tuneβ¦</p> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <input type="url" inputmode="url" aria-label="Base URL" value="https://api.openai.com/v1"/> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <span class="field-label-row">β¦</span> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <span class="field-label-row">β¦</span> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <p class="hint">Cap on the response length. Each model has a tuneβ¦</p> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
-
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L0
1) [chromium] βΊ ui/settings-api-protocol.test.ts:220:1 βΊ [P0] @critical BYOK quick fill provider updates fields and saved settings persist after closing and reopening
Retry #1 βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
Test timeout of 120000ms exceeded.
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L106
1) [chromium] βΊ ui/settings-api-protocol.test.ts:220:1 βΊ [P0] @critical BYOK quick fill provider updates fields and saved settings persist after closing and reopening
Error: locator.click: Test timeout of 120000ms exceeded.
Call log:
- waiting for locator('[data-testid="settings-byok-provider-preset-popover"]').last().getByRole('option', { name: /DeepSeek β OpenAI/i })
- locator resolved to <button type="button" role="option" aria-selected="false" aria-disabled="false" class="model-select-searchable__option" aria-labelledby="model-picker-7r6jgm7d-option-7-label">β¦</button>
- attempting click action
2 Γ waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <p class="hint">Cap on the response length. Each model has a tuneβ¦</p> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <input type="url" inputmode="url" aria-label="Base URL" value="https://api.openai.com/v1"/> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
2 Γ retrying click action
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <span class="field-label-row">β¦</span> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
53 Γ retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <p class="hint">Cap on the response length. Each model has a tuneβ¦</p> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <input type="url" inputmode="url" aria-label="Base URL" value="https://api.openai.com/v1"/> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <span class="field-label-row">β¦</span> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <span class="field-label-row">β¦</span> from <div class="modal-backdrop">β¦</div> subtree intercepts pointer events
- retrying click action
- waiting 500ms
- waiting for element to be visible, enabled and stable
104 | const popover = page.locator(popoverSelector).last();
105 | await expect(popover).toBeVisible();
> 106 | await popover.getByRole('option', { name: optionName }).click();
| ^
107 | }
108 |
109 | async function expectModelComboboxText(
at selectComboboxOption (/home/runner/_work/open-design/open-design/e2e/ui/settings-api-protocol.test.ts:106:59)
at /home/runner/_work/open-design/open-design/e2e/ui/settings-api-protocol.test.ts:242:3
|
|
Run UI P0 domain:
e2e/ui/settings-api-protocol.test.ts#L0
1) [chromium] βΊ ui/settings-api-protocol.test.ts:220:1 βΊ [P0] @critical BYOK quick fill provider updates fields and saved settings persist after closing and reopening
Test timeout of 120000ms exceeded.
|
|
Run UI P0 domain
2 failed
[chromium] βΊ ui/settings-api-protocol.test.ts:220:1 βΊ [P0] @critical BYOK quick fill provider updates fields and saved settings persist after closing and reopening
[chromium] βΊ ui/settings-api-protocol.test.ts:1005:1 βΊ [P0] @critical Settings keeps Local CLI and BYOK model choices isolated after reopening
59 passed (8.9m)
|
background
wait
wait-all
cancel
parallel
Loading