fix(web): keep readonly comment creation available #16971
Annotations
10 errors and 1 notice
|
Run UI P0 domain:
e2e/ui/app-manual-edit.test.ts#L333
5) [chromium] › ui/app-manual-edit.test.ts:325:1 › [P0] @critical preview toolbar keeps share, download, comment, and zoom actions reachable
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toHaveCount(expected) failed
Locator: getByRole('tablist', { name: 'View mode' })
Expected: 0
Received: 1
Timeout: 10000ms
Call log:
- Expect "toHaveCount" with timeout 10000ms
- waiting for getByRole('tablist', { name: 'View mode' })
24 × locator resolved to 1 element
- unexpected value "1"
331 |
332 | await expect(page.getByTestId('artifact-preview-frame')).toBeVisible();
> 333 | await expect(page.getByRole('tablist', { name: 'View mode' })).toHaveCount(0);
| ^
334 |
335 | await page.getByRole('button', { name: /^Share$/ }).click();
336 | const shareMenu = page.locator('.share-menu-popover[role="menu"]');
at /home/runner/work/open-design/open-design/e2e/ui/app-manual-edit.test.ts:333:66
|
|
Run UI P0 domain:
e2e/ui/app-manual-edit.test.ts#L333
5) [chromium] › ui/app-manual-edit.test.ts:325:1 › [P0] @critical preview toolbar keeps share, download, comment, and zoom actions reachable
Error: expect(locator).toHaveCount(expected) failed
Locator: getByRole('tablist', { name: 'View mode' })
Expected: 0
Received: 1
Timeout: 10000ms
Call log:
- Expect "toHaveCount" with timeout 10000ms
- waiting for getByRole('tablist', { name: 'View mode' })
24 × locator resolved to 1 element
- unexpected value "1"
331 |
332 | await expect(page.getByTestId('artifact-preview-frame')).toBeVisible();
> 333 | await expect(page.getByRole('tablist', { name: 'View mode' })).toHaveCount(0);
| ^
334 |
335 | await page.getByRole('button', { name: /^Share$/ }).click();
336 | const shareMenu = page.locator('.share-menu-popover[role="menu"]');
at /home/runner/work/open-design/open-design/e2e/ui/app-manual-edit.test.ts:333:66
|
|
Run UI P0 domain:
e2e/ui/app-manual-edit.test.ts#L322
4) [chromium] › ui/app-manual-edit.test.ts:61:1 › [P0] manual edit inspector previews and persists page and selected element styles
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toContainText(expected) failed
Locator: locator('.manual-edit-modal')
Expected substring: "TYPOGRAPHY"
Received string: "Hero titleCONTENTTextOriginal HeroParametersText colorBackgroundOpacity−+FontinheritSpace GroteskInterTimesArialRobotoHelveticaGeorgiamonospace▾Font size−+Weight700100200300400500600700800900▾Line height−+Letter spacing−+Radius−+Border colorBorder width−+Border style–SolidDashedDottedDoubleNone▾Width−+Height−+Padding▾Top−+Right−+Bottom−+Left−+Margin▾Top−+Right−+Bottom−+Left−+Direction–HorizontalHorizontal reverseVerticalVertical reverse▾Distributionnormal–StartCenterEndSpace betweenSpace aroundSpace evenly▾Gap−+Alignstart–Align leftAlign centerAlign right▾Layout controls are available for flex or grid containers.CancelSave"
Timeout: 10000ms
Call log:
- Expect "toContainText" with timeout 10000ms
- waiting for locator('.manual-edit-modal')
23 × locator resolved to <section class="manual-edit-modal cc-panel">…</section>
- unexpected value "Hero titleCONTENTTextOriginal HeroParametersText colorBackgroundOpacity−+FontinheritSpace GroteskInterTimesArialRobotoHelveticaGeorgiamonospace▾Font size−+Weight700100200300400500600700800900▾Line height−+Letter spacing−+Radius−+Border colorBorder width−+Border style–SolidDashedDottedDoubleNone▾Width−+Height−+Padding▾Top−+Right−+Bottom−+Left−+Margin▾Top−+Right−+Bottom−+Left−+Direction–HorizontalHorizontal reverseVerticalVertical reverse▾Distributionnormal–StartCenterEndSpace betweenSpace aroundSpace evenly▾Gap−+Alignstart–Align leftAlign centerAlign right▾Layout controls are available for flex or grid containers.CancelSave"
320 | await expect(frame.locator(`${selector}[data-od-edit-selected="true"]`)).toHaveCount(1, { timeout: 2_000 });
321 | }).toPass({ timeout: 30_000 });
> 322 | await expect(page.locator('.manual-edit-modal')).toContainText(section);
| ^
323 | }
324 |
325 | test('[P0] @critical preview toolbar keeps share, download, comment, and zoom actions reachable', async ({ page }) => {
at selectPreviewElementThroughBridge (/home/runner/work/open-design/open-design/e2e/ui/app-manual-edit.test.ts:322:52)
at /home/runner/work/open-design/open-design/e2e/ui/app-manual-edit.test.ts:91:3
|
|
Run UI P0 domain:
e2e/ui/app-manual-edit.test.ts#L322
4) [chromium] › ui/app-manual-edit.test.ts:61:1 › [P0] manual edit inspector previews and persists page and selected element styles
Error: expect(locator).toContainText(expected) failed
Locator: locator('.manual-edit-modal')
Expected substring: "TYPOGRAPHY"
Received string: "Hero titleCONTENTTextOriginal HeroParametersText colorBackgroundOpacity−+FontinheritSpace GroteskInterTimesArialRobotoHelveticaGeorgiamonospace▾Font size−+Weight700100200300400500600700800900▾Line height−+Letter spacing−+Radius−+Border colorBorder width−+Border style–SolidDashedDottedDoubleNone▾Width−+Height−+Padding▾Top−+Right−+Bottom−+Left−+Margin▾Top−+Right−+Bottom−+Left−+Direction–HorizontalHorizontal reverseVerticalVertical reverse▾Distributionnormal–StartCenterEndSpace betweenSpace aroundSpace evenly▾Gap−+Alignstart–Align leftAlign centerAlign right▾Layout controls are available for flex or grid containers.CancelSave"
Timeout: 10000ms
Call log:
- Expect "toContainText" with timeout 10000ms
- waiting for locator('.manual-edit-modal')
23 × locator resolved to <section class="manual-edit-modal cc-panel">…</section>
- unexpected value "Hero titleCONTENTTextOriginal HeroParametersText colorBackgroundOpacity−+FontinheritSpace GroteskInterTimesArialRobotoHelveticaGeorgiamonospace▾Font size−+Weight700100200300400500600700800900▾Line height−+Letter spacing−+Radius−+Border colorBorder width−+Border style–SolidDashedDottedDoubleNone▾Width−+Height−+Padding▾Top−+Right−+Bottom−+Left−+Margin▾Top−+Right−+Bottom−+Left−+Direction–HorizontalHorizontal reverseVerticalVertical reverse▾Distributionnormal–StartCenterEndSpace betweenSpace aroundSpace evenly▾Gap−+Alignstart–Align leftAlign centerAlign right▾Layout controls are available for flex or grid containers.CancelSave"
320 | await expect(frame.locator(`${selector}[data-od-edit-selected="true"]`)).toHaveCount(1, { timeout: 2_000 });
321 | }).toPass({ timeout: 30_000 });
> 322 | await expect(page.locator('.manual-edit-modal')).toContainText(section);
| ^
323 | }
324 |
325 | test('[P0] @critical preview toolbar keeps share, download, comment, and zoom actions reachable', async ({ page }) => {
at selectPreviewElementThroughBridge (/home/runner/work/open-design/open-design/e2e/ui/app-manual-edit.test.ts:322:52)
at /home/runner/work/open-design/open-design/e2e/ui/app-manual-edit.test.ts:91:3
|
|
Run UI P0 domain:
e2e/ui/app-design-files.test.ts#L909
3) [chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-tab-persistence: Open file tabs survive refresh with the correct active tab
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toBeVisible() failed
Locator: getByRole('tab', { name: /first-tab\.png/i })
Expected: visible
Timeout: 10000ms
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 10000ms
- waiting for getByRole('tab', { name: /first-tab\.png/i })
907 | buffer: pngBytes,
908 | });
> 909 | await expect(page.getByRole('tab', { name: /first-tab\.png/i })).toBeVisible();
| ^
910 |
911 | await page.getByTestId('design-files-upload-input').setInputFiles({
912 | name: 'second-tab.png',
at runDesignFilesTabPersistenceFlow (/home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:909:68)
at /home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:100:7
|
|
Run UI P0 domain:
e2e/ui/app-design-files.test.ts#L909
3) [chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-tab-persistence: Open file tabs survive refresh with the correct active tab
Error: expect(locator).toBeVisible() failed
Locator: getByRole('tab', { name: /first-tab\.png/i })
Expected: visible
Timeout: 10000ms
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 10000ms
- waiting for getByRole('tab', { name: /first-tab\.png/i })
907 | buffer: pngBytes,
908 | });
> 909 | await expect(page.getByRole('tab', { name: /first-tab\.png/i })).toBeVisible();
| ^
910 |
911 | await page.getByTestId('design-files-upload-input').setInputFiles({
912 | name: 'second-tab.png',
at runDesignFilesTabPersistenceFlow (/home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:909:68)
at /home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:100:7
|
|
Run UI P0 domain:
e2e/ui/app-design-files.test.ts#L487
2) [chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-delete: Design Files panel deletes an uploaded file and clears its tab
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toBeVisible() failed
Locator: getByRole('tab', { name: /keep-me\.png/i })
Expected: visible
Timeout: 10000ms
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 10000ms
- waiting for getByRole('tab', { name: /keep-me\.png/i })
485 | buffer: pngBytes,
486 | });
> 487 | await expect(page.getByRole('tab', { name: /keep-me\.png/i })).toBeVisible();
| ^
488 |
489 | await page.getByTestId('design-files-upload-input').setInputFiles({
490 | name: 'trash-me.png',
at runDesignFilesDeleteFlow (/home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:487:66)
at /home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:96:7
|
|
Run UI P0 domain:
e2e/ui/app-design-files.test.ts#L487
2) [chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-delete: Design Files panel deletes an uploaded file and clears its tab
Error: expect(locator).toBeVisible() failed
Locator: getByRole('tab', { name: /keep-me\.png/i })
Expected: visible
Timeout: 10000ms
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 10000ms
- waiting for getByRole('tab', { name: /keep-me\.png/i })
485 | buffer: pngBytes,
486 | });
> 487 | await expect(page.getByRole('tab', { name: /keep-me\.png/i })).toBeVisible();
| ^
488 |
489 | await page.getByTestId('design-files-upload-input').setInputFiles({
490 | name: 'trash-me.png',
at runDesignFilesDeleteFlow (/home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:487:66)
at /home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:96:7
|
|
Run UI P0 domain:
e2e/ui/app-design-files.test.ts#L450
1) [chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-upload: Design Files panel uploads an image and opens it in the workspace
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toBeVisible() failed
Locator: getByRole('tab', { name: /moodboard\.png/i })
Expected: visible
Timeout: 10000ms
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 10000ms
- waiting for getByRole('tab', { name: /moodboard\.png/i })
448 | });
449 |
> 450 | await expect(page.getByRole('tab', { name: /moodboard\.png/i })).toBeVisible();
| ^
451 | await openAllProjectFiles(page);
452 | // #5517 deleted the preview pane that used to spell out kind / size /
453 | // download for the picked file. The panel's category tab bar is what states
at runDesignFilesUploadFlow (/home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:450:68)
at /home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:92:7
|
|
Run UI P0 domain:
e2e/ui/app-design-files.test.ts#L450
1) [chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-upload: Design Files panel uploads an image and opens it in the workspace
Error: expect(locator).toBeVisible() failed
Locator: getByRole('tab', { name: /moodboard\.png/i })
Expected: visible
Timeout: 10000ms
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 10000ms
- waiting for getByRole('tab', { name: /moodboard\.png/i })
448 | });
449 |
> 450 | await expect(page.getByRole('tab', { name: /moodboard\.png/i })).toBeVisible();
| ^
451 | await openAllProjectFiles(page);
452 | // #5517 deleted the preview pane that used to spell out kind / size /
453 | // download for the picked file. The panel's category tab bar is what states
at runDesignFilesUploadFlow (/home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:450:68)
at /home/runner/work/open-design/open-design/e2e/ui/app-design-files.test.ts:92:7
|
|
Run UI P0 domain
8 failed
[chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-upload: Design Files panel uploads an image and opens it in the workspace
[chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-delete: Design Files panel deletes an uploaded file and clears its tab
[chromium] › ui/app-design-files.test.ts:84:3 › [P0] @critical design-files-tab-persistence: Open file tabs survive refresh with the correct active tab
[chromium] › ui/app-manual-edit.test.ts:61:1 › [P0] manual edit inspector previews and persists page and selected element styles
[chromium] › ui/app-manual-edit.test.ts:325:1 › [P0] @critical preview toolbar keeps share, download, comment, and zoom actions reachable
[chromium] › ui/app-manual-edit.test.ts:746:1 › [P0] @critical edited HTML file restores selected tab and preview after reload
[chromium] › ui/project-management-flows.test.ts:524:1 › [P0] @critical project detail header design system switch carries into the next run request
[chromium] › ui/project-management-flows.test.ts:1513:1 › [P0] clearing the project design system removes designSystemId from the next run request
1 flaky
[chromium] › ui/project-management-flows.test.ts:2358:1 › [P0] project detail share menu opens the current share page for uploaded html artifacts
23 passed (30.6m)
|
background
wait
wait-all
cancel
parallel
Loading