test: expand daemon and UI e2e coverage (#5107)

* test: expand daemon and UI e2e coverage

* fix: refresh retry assistant metadata

Generated-By: looper 0.9.11 (runner=fixer, agent=codex)

* fix: persist inherited run session mode

Generated-By: looper 0.9.11 (runner=fixer, agent=codex)

* fix: stabilize AMR inline auth retry

Generated-By: looper 0.9.11 (runner=fixer, agent=codex)

* fix: reconcile legacy chat assistant pins

Generated-By: looper 0.9.11 (runner=fixer, agent=codex)

* test: stabilize fake AMR auth recovery

Generated-By: looper 0.9.11 (runner=fixer, agent=codex)

* test: restore e2e interaction actionability

Generated-By: looper 0.9.11 (runner=fixer, agent=codex)

* test: address review feedback for PR 5107

* test: stabilize PR 5107 CI interactions

* test: tighten PR 5107 review coverage

* fix: inherit run session mode after conversation fallback

* test: assert AMR promotion retry renders recovery

Generated-By: looper 0.10.1 (runner=fixer, agent=codex)

---------

Co-authored-by: Amy <1184569493@qq.com>

Author: open-design-crew[bot]

apps/daemon/src/routes/project/conversations.ts

@@ -5,14 +5,19 @@ import { backfillBrandExtractionTranscriptForProject } from '../../brands/index.
 import type { RouteDeps } from '../../server-context.js';
 import { registerProjectCommentRoutes } from './comments.js';
 
-export interface RegisterProjectConversationRoutesDeps extends RouteDeps<'db' | 'paths' | 'projectStore' | 'conversations' | 'ids' | 'telemetry' | 'appConfig' | 'agents'> {}
+export interface RegisterProjectConversationRoutesDeps extends RouteDeps<'db' | 'http' | 'paths' | 'projectStore' | 'conversations' | 'ids' | 'telemetry' | 'appConfig' | 'agents'> {}
 
 function normalizeChatSessionMode(value: unknown): ChatSessionMode {
   return value === 'chat' || value === 'plan' ? value : 'design';
 }
 
+function isChatSessionMode(value: unknown): value is ChatSessionMode {
+  return value === 'chat' || value === 'design' || value === 'plan';
+}
+
 export function registerProjectConversationRoutes(app: Express, ctx: RegisterProjectConversationRoutesDeps): void {
   const { db } = ctx;
+  const { sendApiError } = ctx.http;
   const { getProject, updateProject } = ctx.projectStore;
   const {
     insertConversation,
@@ -46,6 +51,9 @@ export function registerProjectConversationRoutes(app: Express, ctx: RegisterPro
     const hasExplicitSessionMode = Boolean(
       req.body && Object.prototype.hasOwnProperty.call(req.body, 'sessionMode'),
     );
+    if (hasExplicitSessionMode && !isChatSessionMode(req.body.sessionMode)) {
+      return sendApiError(res, 400, 'BAD_REQUEST', 'sessionMode must be one of design, chat, or plan');
+    }
     const requestedForkMessageId =
       typeof forkAfterMessageId === 'string' && forkAfterMessageId
         ? forkAfterMessageId
@@ -90,7 +98,7 @@ export function registerProjectConversationRoutes(app: Express, ctx: RegisterPro
     }
     const sessionMode =
       hasExplicitSessionMode
-        ? normalizeChatSessionMode(req.body.sessionMode)
+        ? req.body.sessionMode
         : sourceConversation && sourceConversation.projectId === req.params.id
           ? normalizeChatSessionMode(sourceConversation.sessionMode)
           : 'design';
@@ -129,6 +137,13 @@ export function registerProjectConversationRoutes(app: Express, ctx: RegisterPro
     if (!conv || conv.projectId !== req.params.id) {
       return res.status(404).json({ error: 'not found' });
     }
+    if (
+      req.body &&
+      Object.prototype.hasOwnProperty.call(req.body, 'sessionMode') &&
+      !isChatSessionMode(req.body.sessionMode)
+    ) {
+      return sendApiError(res, 400, 'BAD_REQUEST', 'sessionMode must be one of design, chat, or plan');
+    }
     const updated = updateConversation(db, req.params.cid, req.body || {});
     res.json({ conversation: updated });
   });

apps/daemon/src/routes/runs.ts

@@ -31,7 +31,14 @@ import {
   readCodexRolloutFirstCall,
 } from '../codex-rollout-usage.js';
 import type { ConnectorService } from '../connectors/service.js';
-import { getProject, listConversations, updateProject, upsertMessage } from '../db.js';
+import {
+  getConversation,
+  getProject,
+  listConversations,
+  normalizeConversationSessionMode,
+  updateProject,
+  upsertMessage,
+} from '../db.js';
 import { readVelaLoginStatus } from '../integrations/vela.js';
 import {
   deriveLangfuseDeliveryState,
@@ -140,6 +147,8 @@ interface ChatRun {
   appliedPluginSnapshotId?: string | null;
   pluginId?: string | null;
   clientType?: 'desktop' | 'web';
+  sessionMode?: string | null;
+  context?: Record<string, unknown> | null;
   events: RunEventRecord[];
   clients: Set<SseClient>;
   analyticsContext?: AnalyticsContext;
@@ -635,6 +644,14 @@ export function registerRunRoutes(app: Express, ctx: RegisterRunRoutesDeps) {
         console.warn('[runs] mcp conversation fallback failed', err);
       }
     }
+    const conversationSession =
+      typeof meta.conversationId === 'string' && meta.conversationId
+        ? getConversation(db, meta.conversationId)
+        : null;
+    meta.sessionMode =
+      meta.sessionMode === 'chat' || meta.sessionMode === 'design' || meta.sessionMode === 'plan'
+        ? normalizeConversationSessionMode(meta.sessionMode)
+        : normalizeConversationSessionMode(conversationSession?.sessionMode);
     const run = design.runs.create(meta);
     try {
       pinAssistantMessageOnRunCreate(db, run);
@@ -1433,6 +1450,7 @@ export function registerRunRoutes(app: Express, ctx: RegisterRunRoutesDeps) {
     };
     const run = design.runs.create(meta);
     design.runs.stream(run, req, res);
+    reconcileAssistantMessageOnRunEnd(db, design.runs, run);
     design.runs.start(run, () => startChatRun(meta, run));
   });
 }

apps/daemon/src/runtimes/chat-run-messages.ts

@@ -14,6 +14,8 @@ type ChatRunMessageState = {
   agentId?: string | null;
   status?: string;
   createdAt?: number;
+  sessionMode?: string | null;
+  context?: Record<string, unknown> | null;
 };
 
 function isRecord(value: unknown): value is Record<string, unknown> {
@@ -214,9 +216,18 @@ export function pinAssistantMessageOnRunCreate(db: SqliteDb, run: ChatRunMessage
                 WHEN run_status IN ('succeeded', 'failed', 'canceled') THEN run_status
                 ELSE ?
               END,
+              session_mode = ?,
+              run_context_json = ?,
               started_at = COALESCE(started_at, ?)
         WHERE id = ?`,
-    ).run(run.id, run.status, run.createdAt, run.assistantMessageId);
+    ).run(
+      run.id,
+      run.status,
+      run.sessionMode ?? null,
+      run.context ? JSON.stringify(run.context) : null,
+      run.createdAt,
+      run.assistantMessageId,
+    );
     return;
   }
   upsertMessage(db, run.conversationId, {
@@ -227,6 +238,8 @@ export function pinAssistantMessageOnRunCreate(db: SqliteDb, run: ChatRunMessage
     events: [],
     runId: run.id,
     runStatus: run.status,
+    sessionMode: run.sessionMode ?? undefined,
+    runContext: run.context ?? undefined,
     startedAt: run.createdAt,
   });
 }

apps/daemon/src/runtimes/runs.ts

@@ -70,6 +70,14 @@ export function createChatRunService({
       mediaExecution: normalizeMediaExecutionPolicyForRun(meta.mediaExecution),
       toolBundle: normalizeRunToolBundleForRun(meta.toolBundle),
       browserUse: meta.browserUse && typeof meta.browserUse === 'object' ? meta.browserUse : null,
+      sessionMode:
+        meta.sessionMode === 'chat' || meta.sessionMode === 'design' || meta.sessionMode === 'plan'
+          ? meta.sessionMode
+          : null,
+      context:
+        meta.context && typeof meta.context === 'object' && !Array.isArray(meta.context)
+          ? meta.context
+          : null,
       status: 'queued',
       createdAt: now,
       updatedAt: now,

apps/daemon/tests/chat-route.test.ts

@@ -736,6 +736,62 @@ process.stdin.on('end', () => {
     }
   });
 
+  it('does not leave a pinned assistant message queued when legacy chat fails before spawning', async () => {
+    if (!process.env.OD_DATA_DIR) {
+      throw new Error('OD_DATA_DIR is required for assistant message pin tests');
+    }
+    const projectId = `proj-${randomUUID()}`;
+    const assistantMessageId = `assistant-failed-${randomUUID()}`;
+
+    const createProjectResponse = await fetch(`${baseUrl}/api/projects`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({ id: projectId, name: 'Failed assistant pin fixture' }),
+    });
+    expect(createProjectResponse.ok).toBe(true);
+
+    const conversationsResponse = await fetch(`${baseUrl}/api/projects/${projectId}/conversations`);
+    expect(conversationsResponse.ok).toBe(true);
+    const conversationsBody = await conversationsResponse.json() as {
+      conversations: Array<{ id: string }>;
+    };
+    const conversationId = conversationsBody.conversations[0]?.id;
+    expect(conversationId).toBeTruthy();
+
+    const response = await fetch(`${baseUrl}/api/chat`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({
+        agentId: `missing-agent-${randomUUID()}`,
+        projectId,
+        conversationId,
+        assistantMessageId,
+        message: 'fail before spawn',
+      }),
+    });
+    const body = await response.text();
+    expect(response.ok).toBe(true);
+    expect(body).toContain('unknown agent');
+
+    const dbFile = resolve(process.env.OD_DATA_DIR, 'app.sqlite');
+    let lastStatus: string | null = null;
+    for (let attempt = 0; attempt < 100; attempt += 1) {
+      const sqlite = new Database(dbFile, { readonly: true });
+      try {
+        const row = sqlite
+          .prepare(`SELECT run_status FROM messages WHERE id = ?`)
+          .get(assistantMessageId) as { run_status: string | null } | undefined;
+        lastStatus = row?.run_status ?? null;
+        if (lastStatus && lastStatus !== 'queued' && lastStatus !== 'running') break;
+      } finally {
+        sqlite.close();
+      }
+      await new Promise((resolve) => setTimeout(resolve, 25));
+    }
+
+    expect(lastStatus).toBe('failed');
+  });
+
   it('rewrites the OpenCode scanner overflow into a generic retry message', async () => {
     const conversationId = `conv-${randomUUID()}`;
 

apps/daemon/tests/mcp-get-artifact.test.ts

@@ -3,7 +3,7 @@ import type { AddressInfo } from 'node:net';
 import express from 'express';
 import type { Express } from 'express';
 import { afterAll, beforeAll, describe, expect, it } from 'vitest';
-import { getArtifact, fetchProjectFile } from '../src/mcp.js';
+import { getArtifact, fetchProjectFile, handleMcpToolCall } from '../src/mcp.js';
 
 // A minimal mock of the daemon's project file endpoints. Tests control
 // the file list and per-file response via the opts object.
@@ -178,3 +178,54 @@ describe('getArtifact truncated: true when per-file content-length pre-check fir
     expect(body.files.length).toBe(1);
   });
 });
+
+describe('public MCP get_artifact active context defaults', () => {
+  let server: http.Server;
+  let baseUrl: string;
+
+  beforeAll(async () => {
+    const app = express();
+    app.get('/api/active', (_req, res) =>
+      res.json({
+        active: true,
+        projectId: 'active-project',
+        projectName: 'Active Project',
+        fileName: 'landing.html',
+        ageMs: 50,
+      }),
+    );
+    app.get('/api/projects/:id', (_req, res) =>
+      res.json({
+        project: {
+          id: 'active-project',
+          name: 'Active Project',
+          metadata: { entryFile: 'index.html' },
+        },
+      }),
+    );
+    app.get('/api/projects/:id/raw/*splat', (req, res) => {
+      expect(req.params.id).toBe('active-project');
+      expect(req.params.splat).toEqual(['landing.html']);
+      res.set({ 'content-type': 'text/html' }).send('<!doctype html><h1>Active artifact</h1>');
+    });
+    const r = await startServer(app);
+    server = r.server;
+    baseUrl = r.baseUrl;
+  });
+
+  afterAll(() => new Promise((resolve) => server.close(resolve)));
+
+  it('uses the active file ahead of metadata.entryFile when project and entry are omitted', async () => {
+    const result = await handleMcpToolCall(baseUrl, 'get_artifact', { include: 'shallow' });
+    const body = parseArtifactBody(firstText(result.content)) as ArtifactBody & {
+      entryFile?: string;
+      usedActiveContext?: { projectId?: string; fileName?: string };
+    };
+    expect(body.entryFile).toBe('landing.html');
+    expect(body.files).toHaveLength(1);
+    expect(body.usedActiveContext).toMatchObject({
+      projectId: 'active-project',
+      fileName: 'landing.html',
+    });
+  });
+});

apps/daemon/tests/mcp-get-file.test.ts

@@ -3,7 +3,7 @@ import type { AddressInfo } from 'node:net';
 import express from 'express';
 import type { Express } from 'express';
 import { afterAll, beforeAll, describe, expect, it } from 'vitest';
-import { getFile } from '../src/mcp.js';
+import { getFile, handleMcpToolCall } from '../src/mcp.js';
 
 const PROJECT_ID = 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa';
 
@@ -131,3 +131,38 @@ describe('getFile binary rejection unchanged', () => {
     expect(text).toMatch(/binary content is not yet supported/);
   });
 });
+
+describe('public MCP get_file active context defaults', () => {
+  let server: http.Server;
+  let baseUrl: string;
+
+  beforeAll(async () => {
+    const app = express();
+    app.get('/api/active', (_req, res) =>
+      res.json({
+        active: true,
+        projectId: 'active-project',
+        projectName: 'Active Project',
+        fileName: 'landing.html',
+        ageMs: 25,
+      }),
+    );
+    app.get('/api/projects/:id/raw/*splat', (req, res) => {
+      expect(req.params.id).toBe('active-project');
+      expect(req.params.splat).toEqual(['landing.html']);
+      res.set({ 'content-type': 'text/html' }).send('<!doctype html><h1>Active file</h1>');
+    });
+    const r = await startServer(app);
+    server = r.server;
+    baseUrl = r.baseUrl;
+  });
+
+  afterAll(() => new Promise((resolve) => server.close(resolve)));
+
+  it('uses the active project and active file when project and path are omitted', async () => {
+    const result = await handleMcpToolCall(baseUrl, 'get_file', {});
+    const textParts = contentTexts(result.content);
+    expect(textParts[0]).toContain('[od:active-context project="Active Project" file="landing.html"]');
+    expect(lastText(textParts)).toContain('<h1>Active file</h1>');
+  });
+});