fix(daemon): make od conversation info actually work and stop reporting 404 as daemon-not-running (#6116)

`od conversation info <conversationId>` always 404ed because:
1. `case 'info'` fetched the unscoped route
   `/api/conversations/<id>`, but the daemon only serves
   project-scoped routes (`/api/projects/:id/conversations/...`).
2. There was no GET handler for a single conversation — only
   PATCH and DELETE — so even with the right scope the request
   would have 404ed.
3. The 404 got mapped to `code: 'daemon-not-running'`, sending
   users on a wild-goose chase checking daemon sockets when the
   daemon was actually fine.

Fix:
- Add a project-scoped GET handler for
  `/api/projects/:id/conversations/:cid` that returns the
  conversation object.
- Make `case 'info'` use `--project <id> <conversationId>`
  (consistent with `od conversation list <projectId>`) and
  hit the project-scoped route through `positionalArgs` so a
  flag value isn't mistaken for the conversation id.
- On a 404 use `fallbackCode: 'not-found'` instead of the
  misleading `'daemon-not-running'`. The daemon answered —
  that's literally what a 404 proves.

Regression test `conversation-info-cli.test.ts` pins all three
behaviors: success path hits the scoped route (verifies the
exact request URL seen by a stub HTTP server), 404 path emits
`not-found` and never `daemon-not-running`, and the
missing-`--project` path bails with the new usage line.

Closes #6116.

Co-authored-by: Nicholas-Xiong <2482929840@qq.com>
Signed-off-by: xxiaoxiong <2482929840@qq.com>

Author: xxiaoxiong

apps/daemon/src/cli.ts

@@ -7146,13 +7146,18 @@ Common options:
       return;
     }
     case 'info': {
-      const id = rest.find((a) => !a.startsWith('-'));
-      if (!id) {
-        console.error('Usage: od conversation info <conversationId>');
+      const projectId = typeof flags.project === 'string' && flags.project
+        ? flags.project
+        : null;
+      const id = positionalArgs(rest, PROJECT_STRING_FLAGS)[0];
+      if (!projectId || !id) {
+        console.error('Usage: od conversation info --project <projectId> <conversationId>');
         process.exit(2);
       }
-      const resp = await fetch(`${base}/api/conversations/${encodeURIComponent(id)}`);
-      if (!resp.ok) return structuredHttpFailure(resp);
+      const resp = await fetch(
+        `${base}/api/projects/${encodeURIComponent(projectId)}/conversations/${encodeURIComponent(id)}`,
+      );
+      if (!resp.ok) return structuredHttpFailure(resp, resp.status === 404 ? 'not-found' : 'daemon-not-running');
       const data = await resp.json();
       process.stdout.write(JSON.stringify(data, null, 2) + '\n');
       return;

apps/daemon/src/routes/project/conversations.ts

@@ -133,6 +133,17 @@ export function registerProjectConversationRoutes(app: Express, ctx: RegisterPro
     res.json({ conversation: conv });
   });
 
+  app.get('/api/projects/:id/conversations/:cid', (req, res) => {
+    // Project-scoped GET for a single conversation. Previously the
+    // only per-conversation verbs were PATCH/DELETE; `od conversation
+    // info <cid>` therefore had nothing to hit and 404ed (issue #6116).
+    const conv = getConversation(db, req.params.cid);
+    if (!conv || conv.projectId !== req.params.id) {
+      return res.status(404).json({ error: 'not found' });
+    }
+    res.json({ conversation: conv });
+  });
+
   app.patch('/api/projects/:id/conversations/:cid', (req, res) => {
     const conv = getConversation(db, req.params.cid);
     if (!conv || conv.projectId !== req.params.id) {

apps/daemon/tests/conversation-info-cli.test.ts

@@ -0,0 +1,128 @@
+// Regression for `od conversation info` always 404ing (#6116):
+// `case 'info'` used to fetch the unscoped route
+// `/api/conversations/<id>`, but the daemon only serves
+// project-scoped routes (`/api/projects/:id/conversations/…`). The
+// 404 then mapped to `daemon-not-running`, sending users on a wild
+// goose chase checking daemon sockets.
+//
+// Fix:
+//   1. `od conversation info --project <id> <conversationId>` hits
+//      the project-scoped route.
+//   2. 404 now exits with `not-found`, not `daemon-not-running`.
+
+import { execFile } from 'node:child_process';
+import http from 'node:http';
+import { promisify } from 'node:util';
+import { fileURLToPath } from 'node:url';
+import { describe, expect, it } from 'vitest';
+
+const execFileAsync = promisify(execFile);
+const cliEntry = fileURLToPath(new URL('../src/cli.ts', import.meta.url));
+
+describe('od conversation info CLI', () => {
+  it('hits the project-scoped conversation route and prints the conversation', async () => {
+    const seenRequests: Array<{ method: string; url: string }> = [];
+    const server = http.createServer((req, res) => {
+      let body = '';
+      req.setEncoding('utf8');
+      req.on('data', (chunk) => {
+        body += chunk;
+      });
+      req.on('end', () => {
+        seenRequests.push({ method: req.method ?? '', url: req.url ?? '' });
+        if (req.method === 'GET' && req.url === '/api/projects/proj-1/conversations/conv-9') {
+          res.writeHead(200, { 'content-type': 'application/json' });
+          res.end(JSON.stringify({
+            conversation: { id: 'conv-9', projectId: 'proj-1', title: 'Demo' },
+            messages: [],
+          }));
+          return;
+        }
+        res.writeHead(404, { 'content-type': 'application/json' });
+        res.end(JSON.stringify({ error: 'not found' }));
+      });
+    });
+    await new Promise<void>((resolve) => server.listen(0, '127.0.0.1', resolve));
+    const address = server.address();
+    if (!address || typeof address === 'string') throw new Error('server did not bind');
+    const port = address.port;
+
+    try {
+      let stdout = '';
+      try {
+        const r = await execFileAsync(
+          process.execPath,
+          [
+            '--import',
+            'tsx',
+            cliEntry,
+            'conversation',
+            'info',
+            '--project', 'proj-1',
+            'conv-9',
+            '--daemon-url', `http://127.0.0.1:${port}`,
+            '--json',
+          ],
+        );
+        stdout = r.stdout;
+      } catch (err) {
+        const e = err as NodeJS.ErrnoException & { stdout?: string; stderr?: string };
+        stdout = e.stdout ?? '';
+      }
+      const parsed = JSON.parse(stdout);
+      expect(parsed.conversation.id).toBe('conv-9');
+      // Confirm we hit the project-scoped route, not the broken unscoped one.
+      expect(seenRequests).toContainEqual({ method: 'GET', url: '/api/projects/proj-1/conversations/conv-9' });
+      expect(seenRequests.some((r) => r.url === '/api/conversations/conv-9')).toBe(false);
+    } finally {
+      server.close();
+    }
+  });
+
+  it('exits with `not-found` (not daemon-not-running) when the conversation is missing', async () => {
+    const server = http.createServer((req, res) => {
+      req.resume();
+      res.writeHead(404, { 'content-type': 'application/json' });
+      res.end(JSON.stringify({ error: 'not found' }));
+    });
+    await new Promise<void>((resolve) => server.listen(0, '127.0.0.1', resolve));
+    const address = server.address();
+    if (!address || typeof address === 'string') throw new Error('server did not bind');
+    const port = address.port;
+
+    try {
+      const result = await execFileAsync(
+        process.execPath,
+        [
+          '--import', 'tsx', cliEntry,
+          'conversation', 'info',
+          '--project', 'proj-1',
+          'conv-missing',
+          '--daemon-url', `http://127.0.0.1:${port}`,
+          '--json',
+        ],
+      ).catch((err: NodeJS.ErrnoException & { stdout?: string; stderr?: string }) => err);
+
+      // 404 should produce a non-zero exit, AND the structured error
+      // payload should use `not-found` rather than the misleading
+      // `daemon-not-running` code.
+      expect(result.code).toBeTruthy();
+      const stderr = (result as { stderr?: string }).stderr ?? '';
+      expect(stderr).toContain('"code":');
+      expect(stderr).toContain('"not-found"');
+      expect(stderr).not.toContain('daemon-not-running');
+    } finally {
+      server.close();
+    }
+  });
+
+  it('prints usage and exits non-zero when --project is missing', async () => {
+    const result = await execFileAsync(
+      process.execPath,
+      ['--import', 'tsx', cliEntry, 'conversation', 'info', 'conv-9', '--json'],
+    ).catch((err: NodeJS.ErrnoException & { stdout?: string; stderr?: string }) => err);
+    expect(result.code).toBeTruthy();
+    const stderr = (result as { stderr?: string }).stderr ?? '';
+    expect(stderr).toContain('Usage: od conversation info --project <projectId> <conversationId>');
+  });
+});