Skip to content

fix: resolve clippy warnings and improve code quality#384

Closed
strmfos wants to merge 1 commit intonexus-xyz:mainfrom
strmfos:main
Closed

fix: resolve clippy warnings and improve code quality#384
strmfos wants to merge 1 commit intonexus-xyz:mainfrom
strmfos:main

Conversation

@strmfos
Copy link

@strmfos strmfos commented Apr 3, 2025

Fix Clippy Warnings

  • Added #[nexus_rt::main] attribute to main functions
  • Fixed custom_input/custom_output attribute formats
  • Added conditional compilation for non-riscv32 targets
  • Changed function return types to Result
  • Extracted complex types into type definitions
  • Fixed imports and removed unnecessary references
    All tests passed

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@strmfos
Copy link
Author

strmfos commented Apr 3, 2025

I have read the CLA Document and I hereby sign the CLA

@sjudson
Copy link
Contributor

sjudson commented Apr 17, 2025

Thanks for the PR. Generally speaking however, we prefer not to merge purely cosmetic changes, so I'm going to close for now.

@sjudson sjudson closed this Apr 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants