fix: update ELF parser tests to use existing test files#385
Closed
VolodymyrBg wants to merge 1 commit intonexus-xyz:mainfrom
Closed
fix: update ELF parser tests to use existing test files#385VolodymyrBg wants to merge 1 commit intonexus-xyz:mainfrom
VolodymyrBg wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Thanks for catching this, there is some ongoing internal work that should fix these tests more comprehensively, so I'm going to prioritize that approach (cc: @bhoberman). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this resolving a feature or a bug?
When I ran tests I bumped into this fail:
test elf::parser::tests::test_parse_elf_file_with_no_precompiles stdout ----
thread 'elf::parser::tests::test_parse_elf_file_with_no_precompiles' panicked at vm\src\elf\parser.rs:556:49:
called
Result::unwrap()on anErrvalue: Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }note: run with
RUST_BACKTRACE=1environment variable to display a backtrace---- elf::parser::tests::test_parse_elf_file_with_precompile stdout ----
thread 'elf::parser::tests::test_parse_elf_file_with_precompile' panicked at vm\src\elf\parser.rs:523:49:
called
Result::unwrap()on anErrvalue: Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }---- elf::parser::tests::test_parse_elf_file_with_precompiles stdout ----
thread 'elf::parser::tests::test_parse_elf_file_with_precompiles' panicked at vm\src\elf\parser.rs:538:49:
called
Result::unwrap()on anErrvalue: Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }Describe your changes.
The tests in vm/src/elf/parser.rs were failing because they were looking
for non-existent test files. This commit updates the tests to use the
actual test files available in the project.
Tests previously failed with errors:
"Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }"
Modified test files:
Also fixes unused variable warnings by prefixing variables with underscore.