fix: unsafe unwrap usage in into_string() conversion#388
Closed
famouswizard wants to merge 1 commit intonexus-xyz:mainfrom
Closed
fix: unsafe unwrap usage in into_string() conversion#388famouswizard wants to merge 1 commit intonexus-xyz:mainfrom
into_string() conversion#388famouswizard wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
sjudson
suggested changes
Apr 17, 2025
| let mut dest = match std::env::var_os("OUT_DIR") { | ||
| Some(path) => path.into_string().unwrap(), | ||
| None => "/tmp/nexus-target".into(), | ||
| Some(path) => path.into_string().unwrap_or_else(|_| "/tmp/nexus-target".to_string()), |
Contributor
There was a problem hiding this comment.
I think it would be nice to make this more robust, but if this path is invalidly set we should return a BuildError (rather than panicking), not fall back to the default.
chuckyLeeVIII
pushed a commit
to chuckyLeeVIII/nexus-zkvm
that referenced
this pull request
Apr 18, 2025
Summary: Fixes nexus-xyz#386 Test Plan: Co-authored-by: duc-nx <>
sjudson
pushed a commit
that referenced
this pull request
May 14, 2025
Summary: Fixes #386 Test Plan: Co-authored-by: duc-nx <>
Contributor
|
Closing due to inactivity... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes.
i replaced the unsafe
unwrap()call in theinto_string()conversion with a safer error handling approach.this prevents potential panics when the conversion fails and ensures the program behaves more reliably.